bump solana docker image's based image to bookworm#3977
Merged
Conversation
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
willhickey
approved these changes
Dec 6, 2024
Member
Author
|
we don't have any tests covering this change. merge it on red. |
mergify Bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
(cherry picked from commit b3c2274)
|
aside: why are the docker images debian instead of ubuntu? i know they're usually close enough, but seems like an unnecessary divergence |
willhickey
pushed a commit
that referenced
this pull request
Dec 6, 2024
KirillLykov
pushed a commit
that referenced
this pull request
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I bumped our build image to ubuntu 22.04 (#3774) but forgot to upgrade sdk's base image to the corresponding one
context: https://discord.com/channels/428295358100013066/670512312339398668/1314633956058202154
Summary of Changes
bump solana docker image's based image to bookworm
Note:
we build bins in the build image (https://github.com/anza-xyz/agave/blob/master/ci/docker/Dockerfile) then copy to the sdk image (https://github.com/anza-xyz/agave/blob/master/sdk/docker-solana/Dockerfile)