Skip to content

bump solana docker image's based image to bookworm#3977

Merged
yihau merged 1 commit into
anza-xyz:masterfrom
yihau:fix-docker-image
Dec 6, 2024
Merged

bump solana docker image's based image to bookworm#3977
yihau merged 1 commit into
anza-xyz:masterfrom
yihau:fix-docker-image

Conversation

@yihau
Copy link
Copy Markdown
Member

@yihau yihau commented Dec 6, 2024

Problem

I bumped our build image to ubuntu 22.04 (#3774) but forgot to upgrade sdk's base image to the corresponding one

context: https://discord.com/channels/428295358100013066/670512312339398668/1314633956058202154

$> docker run --rm -ti anzaxyz/agave:v2.1.4 agave-validator -h

solana-faucet: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by solana-faucet)
solana-faucet: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by solana-faucet)
solana-faucet: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by solana-faucet)
...

Summary of Changes

bump solana docker image's based image to bookworm


Note:

we build bins in the build image (https://github.com/anza-xyz/agave/blob/master/ci/docker/Dockerfile) then copy to the sdk image (https://github.com/anza-xyz/agave/blob/master/sdk/docker-solana/Dockerfile)

@yihau yihau added the v2.1 label Dec 6, 2024
@yihau yihau requested review from t-nelson and willhickey December 6, 2024 17:17
@mergify
Copy link
Copy Markdown

mergify Bot commented Dec 6, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@yihau
Copy link
Copy Markdown
Member Author

yihau commented Dec 6, 2024

we don't have any tests covering this change. merge it on red.

@yihau yihau merged commit b3c2274 into anza-xyz:master Dec 6, 2024
@yihau yihau deleted the fix-docker-image branch December 6, 2024 17:23
mergify Bot pushed a commit that referenced this pull request Dec 6, 2024
@t-nelson
Copy link
Copy Markdown

t-nelson commented Dec 6, 2024

aside: why are the docker images debian instead of ubuntu? i know they're usually close enough, but seems like an unnecessary divergence

willhickey pushed a commit that referenced this pull request Dec 6, 2024
…3977) (#3978)

bump solana docker image's based image to bookworm (#3977)

(cherry picked from commit b3c2274)

Co-authored-by: Yihau Chen <yihau.chen@icloud.com>
KirillLykov pushed a commit that referenced this pull request Dec 9, 2024
…3977) (#3978)

bump solana docker image's based image to bookworm (#3977)

(cherry picked from commit b3c2274)

Co-authored-by: Yihau Chen <yihau.chen@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants