v2.1: instruction: Derive everything for wasm build (backport of #3606)#3610
Merged
v2.1: instruction: Derive everything for wasm build (backport of #3606)#3610
Conversation
#### Problem As noticed in solana-labs/solana-program-library#7489, the wasm build for `Instruction` doesn't contain `Clone`. This is because we missed the derivations for the wasm version of `Instruction` in #1658. #### Summary of changes Looking back through that PR, I noticed that we only missed those additional derives on `Instruction`, so just fix those in `Instruction`. Since this is fixing a small regression for wasm builds, I think we should backport the change to v2.1. (cherry picked from commit d3bce9f)
samkim-crypto
approved these changes
Nov 14, 2024
t-nelson
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As noticed in
solana-labs/solana-program-library#7489, the wasm build for
Instructiondoesn't containClone. This is because we missed the derivations for the wasm version ofInstructionin #1658.Summary of changes
Looking back through that PR, I noticed that we only missed those additional derives on
Instruction, so just fix those inInstruction.Since this is fixing a small regression for wasm builds, I think we should backport the change to v2.1.
This is an automatic backport of pull request #3606 done by Mergify.