instruction: Derive everything for wasm build#3606
Merged
mergify[bot] merged 1 commit intoanza-xyz:masterfrom Nov 13, 2024
Merged
instruction: Derive everything for wasm build#3606mergify[bot] merged 1 commit intoanza-xyz:masterfrom
mergify[bot] merged 1 commit intoanza-xyz:masterfrom
Conversation
#### Problem As noticed in solana-labs/solana-program-library#7489, the wasm build for `Instruction` doesn't contain `Clone`. This is because we missed the derivations for the wasm version of `Instruction` in anza-xyz#1658. #### Summary of changes Looking back through that PR, I noticed that we only missed those additional derives on `Instruction`, so just fix those in `Instruction`. Since this is fixing a small regression for wasm builds, I think we should backport the change to v2.1.
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
kevinheavey
approved these changes
Nov 13, 2024
samkim-crypto
approved these changes
Nov 13, 2024
joncinque
added
the
automerge
mergify Bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
#### Problem As noticed in solana-labs/solana-program-library#7489, the wasm build for `Instruction` doesn't contain `Clone`. This is because we missed the derivations for the wasm version of `Instruction` in #1658. #### Summary of changes Looking back through that PR, I noticed that we only missed those additional derives on `Instruction`, so just fix those in `Instruction`. Since this is fixing a small regression for wasm builds, I think we should backport the change to v2.1. (cherry picked from commit d3bce9f)
joncinque
added a commit
that referenced
this pull request
Nov 18, 2024
… (#3610) instruction: Derive everything for wasm build (#3606) #### Problem As noticed in solana-labs/solana-program-library#7489, the wasm build for `Instruction` doesn't contain `Clone`. This is because we missed the derivations for the wasm version of `Instruction` in #1658. #### Summary of changes Looking back through that PR, I noticed that we only missed those additional derives on `Instruction`, so just fix those in `Instruction`. Since this is fixing a small regression for wasm builds, I think we should backport the change to v2.1. (cherry picked from commit d3bce9f) Co-authored-by: Jon C <me@jonc.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As noticed in
solana-labs/solana-program-library#7489, the wasm build for
Instructiondoesn't containClone. This is because we missed the derivations for the wasm version ofInstructionin #1658.Summary of changes
Looking back through that PR, I noticed that we only missed those additional derives on
Instruction, so just fix those inInstruction.Since this is fixing a small regression for wasm builds, I think we should backport the change to v2.1.