don't ignore doc examples in secp256k1-recover#3229
Merged
mergify[bot] merged 1 commit intoanza-xyz:masterfrom Oct 20, 2024
Merged
don't ignore doc examples in secp256k1-recover#3229mergify[bot] merged 1 commit intoanza-xyz:masterfrom
mergify[bot] merged 1 commit intoanza-xyz:masterfrom
Conversation
yihau
approved these changes
Oct 20, 2024
ray-kast
pushed a commit
to abklabs/agave
that referenced
this pull request
Nov 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In #1656 I added
ignoreto some doc examples because the CI at the time didn't allow us to have asolana_programdev dep in this crate. Now it does allow this.Summary of Changes
Remove one
ignoreand replace the other two withno_runso the examples are tested/compiled as before