Move secp256k1_recover to its own crate#1656
Merged
samkim-crypto merged 23 commits intoanza-xyz:masterfrom Jul 17, 2024
Merged
Conversation
Author
|
The circular dependency check is failing but the premise of the check is wrong. It's complaining about the recommended way to activate a feature in tests: https://stackoverflow.com/questions/68618789/is-it-possible-to-enable-a-rust-feature-only-in-test Update: turns out I don't need that to make the tests pass so we can worry about it another time |
Author
|
Coverage failure means nothing to me: |
kevinheavey
force-pushed
the
move-secp256k1
branch
from
facb162 to
caf046e
Compare
0x0ece
reviewed
Jun 11, 2024
kevinheavey
force-pushed
the
move-secp256k1
branch
5 times, most recently
from
0d42f21 to
9415e53
Compare
kevinheavey
force-pushed
the
move-secp256k1
branch
from
9415e53 to
d0e6bf3
Compare
kevinheavey
force-pushed
the
move-secp256k1
branch
from
d0e6bf3 to
b1cf5e9
Compare
kevinheavey
force-pushed
the
move-secp256k1
branch
2 times, most recently
from
2975708 to
920ca4a
Compare
Author
|
@samkim-crypto after some frozen-abi adventures, all CI except for crate-check is now passing |
kevinheavey
force-pushed
the
move-secp256k1
branch
3 times, most recently
from
2d2ab60 to
75b79e7
Compare
…es-for-publishing.py
This reverts commit 86e8671.
kevinheavey
force-pushed
the
move-secp256k1
branch
from
75b79e7 to
3f33a1c
Compare
samkim-crypto
approved these changes
Jul 17, 2024
samkim-crypto
left a comment
samkim-crypto
left a comment
There was a problem hiding this comment.
Looks good! Thanks a lot for all these changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
libsecp256k1 is a heavy dependency and the use case is niche
Summary of Changes
Moves secp256k1_recover out of solana-program and into its own crate. Re-export with deprecation notice