Skip to content

v1.18: rpc: add more services to getClusterNodes (backport of #1637)#2164

Merged
t-nelson merged 1 commit intov1.18from
mergify/bp/v1.18/pr-1637
Aug 28, 2024
Merged

v1.18: rpc: add more services to getClusterNodes (backport of #1637)#2164
t-nelson merged 1 commit intov1.18from
mergify/bp/v1.18/pr-1637

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented Jul 17, 2024

Problem

Not possible to get a TPU forward address for light clients.

Summary of Changes

Add tpu_forwards and tpu_forwards_quic to getClusterNodes.


This is an automatic backport of pull request #1637 done by Mergify.

* rpc: add tpu_forwards/tpu_forwards_quic to getClusterNodes

* add tvu

* order

* add tpu_vote

* add serve_repair

* fix tests

* fix name in tests

* remove tvu / repair quic

(cherry picked from commit dbea20b)
@mergify mergify Bot requested a review from a team as a code owner July 17, 2024 08:00
@mergify
Copy link
Copy Markdown
Author

mergify Bot commented Jul 17, 2024

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @mergify[bot].

@t-nelson
Copy link
Copy Markdown

If this PR represents a change to the public RPC API:

1. Make sure it includes a complementary update to `rpc-client/` ([example](https://github.com/solana-labs/solana/pull/29558/files))

2. Open a follow-up PR to update the JavaScript client `@solana/web3.js` ([example](https://github.com/solana-labs/solana-web3.js/pull/2868/files))

Thank you for keeping the RPC clients in sync with the server API @mergify[bot].

what triggers this message? would be good to get it on the master PR before merge rather than on BP when it's too late

@CriesofCarrots
Copy link
Copy Markdown

CriesofCarrots commented Jul 23, 2024

what triggers this message? would be good to get it on the master PR before merge rather than on BP when it's too late

@t-nelson #1904
Plenty of examples of the message on master PRs. In this case, you necro-backported an old PR.

@t-nelson
Copy link
Copy Markdown

ah so we added that message after the master pr was merged? wasn't clear since it got triggered on that pr with the bp tag messages

@t-nelson
Copy link
Copy Markdown

@CriesofCarrots you willing to SME review this one? 🙏

@t-nelson t-nelson merged commit 11e166f into v1.18 Aug 28, 2024
@t-nelson t-nelson deleted the mergify/bp/v1.18/pr-1637 branch August 28, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants