chore: Mergify now gently nudges folks who update RPC code to also update the Rust and JavaScript clients#1904
Merged
steveluscher merged 1 commit intoanza-xyz:masterfrom Jun 29, 2024
Conversation
…date the Rust and JavaScript clients
steveluscher
commented
Jun 28, 2024
Comment on lines
+174
to
+176
| - files~=^rpc/src/rpc\.rs$ | ||
| - files~=^rpc/src/rpc_pubsub\.rs$ | ||
| - files~=^rpc-client-api/src/.*\.rs$ |
Author
There was a problem hiding this comment.
I think this about covers the files that could possibly have an impact on the public RPC API. If you think that we should just dragnet every .rs file in rpc/ and rpc-client-api/ then I can do that too!
There was a problem hiding this comment.
This seems like a good place to start
CriesofCarrots
approved these changes
Jun 28, 2024
Comment on lines
+174
to
+176
| - files~=^rpc/src/rpc\.rs$ | ||
| - files~=^rpc/src/rpc_pubsub\.rs$ | ||
| - files~=^rpc-client-api/src/.*\.rs$ |
There was a problem hiding this comment.
This seems like a good place to start
steveluscher
deleted the
gently-nudge-rpc-modifiers-to-keep-the-clients-in-sync
branch
samkim-crypto
pushed a commit
to samkim-crypto/agave
that referenced
this pull request
Jul 31, 2024
…date the Rust and JavaScript clients (anza-xyz#1904)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Sometimes folks add, remove, or deprecate parts of the RPC server API but don't make a related change to the Rust/JavaScript clients.
Summary of Changes
This PR makes Mergify comment on PRs that change these files, gently suggesting that the author make a change to the clients.
Test Plan
Tested in the Mergify console on PR #69.