Bring rBPF source files to the monorepo#1850
Closed
LucasSte wants to merge 8 commits intoanza-xyz:masterfrom
Closed
Bring rBPF source files to the monorepo#1850LucasSte wants to merge 8 commits intoanza-xyz:masterfrom
LucasSte wants to merge 8 commits intoanza-xyz:masterfrom
Conversation
LucasSte
force-pushed
the
rbpf-part1
branch
6 times, most recently
from
289d5c0 to
eea1a30
Compare
Author
|
The CI is failing because we need to transfer the crate's ownership to |
LucasSte
changed the title
Author
|
Closing this PR in favor of #1842 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The rBPF create is an integral part of the validator, however it sits outside of the monorepo, hindering updates, security responses and bug fixes.
Summary of Changes
I brought the crate to the monorepo, and configured the CI (clippy, tests and fmt). The complete work is in #1842, but it touches on more than 20k lines, so the CI can't run. I'm splitting it in smaller changes. The test and bench files will come in another PR.
I yanked the
test-utilscreates and created the necessary functions insrc/utils.rs, because it contained a cyclic dependency.