Bring the rBPF crate to the monorepo#1842
Closed
LucasSte wants to merge 12 commits intoanza-xyz:masterfrom
Closed
Conversation
80d2c5c to
292f7b9
Compare
Author
|
The failure in the CI happens because we need to transfer the crate's ownership to |
Author
Lichtso
approved these changes
Jul 1, 2024
Author
|
We are not merging at this time, since we are potentially splitting the SVM into its own repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The rBPF create is an integral part of the validator, however it sits outside of the monorepo, hindering updates, security responses and bug fixes.
Summary of Changes
I brought the crate to the monorepo, and configured the CI (clippy, tests and fmt).
For a next PR, I'll set up the
cargo fuzzjob in the CI. It is not done here, because it requires changing the docker container.