Skip to content

Bring the rBPF crate to the monorepo#1842

Closed
LucasSte wants to merge 12 commits intoanza-xyz:masterfrom
LucasSte:rbpf-crate
Closed

Bring the rBPF crate to the monorepo#1842
LucasSte wants to merge 12 commits intoanza-xyz:masterfrom
LucasSte:rbpf-crate

Conversation

@LucasSte
Copy link
Copy Markdown

Problem

The rBPF create is an integral part of the validator, however it sits outside of the monorepo, hindering updates, security responses and bug fixes.

Summary of Changes

I brought the crate to the monorepo, and configured the CI (clippy, tests and fmt).

For a next PR, I'll set up the cargo fuzz job in the CI. It is not done here, because it requires changing the docker container.

@LucasSte LucasSte changed the title Bring the rBPF crate to the monorepo [Not working] Bring the rBPF crate to the monorepo Jun 24, 2024
@LucasSte LucasSte changed the title [Not working] Bring the rBPF crate to the monorepo [DRAFT] Bring the rBPF crate to the monorepo Jun 24, 2024
@LucasSte LucasSte force-pushed the rbpf-crate branch 5 times, most recently from 80d2c5c to 292f7b9 Compare June 28, 2024 21:02
@LucasSte
Copy link
Copy Markdown
Author

The failure in the CI happens because we need to transfer the crate's ownership to anza-team.

@LucasSte LucasSte marked this pull request as ready for review June 29, 2024 23:48
@LucasSte LucasSte requested review from Lichtso and alessandrod June 29, 2024 23:48
@LucasSte LucasSte changed the title [DRAFT] Bring the rBPF crate to the monorepo Bring the rBPF crate to the monorepo Jun 29, 2024
@LucasSte
Copy link
Copy Markdown
Author

LucasSte commented Jul 1, 2024

@yihau has already worked on adding cargo fuzz build in the checks pipeline: #1932, but we need to have this PR merged before that one.

@LucasSte
Copy link
Copy Markdown
Author

LucasSte commented Jul 2, 2024

We are not merging at this time, since we are potentially splitting the SVM into its own repository.

@LucasSte LucasSte closed this Jul 2, 2024
@LucasSte LucasSte deleted the rbpf-crate branch July 2, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants