Refactor - Move SBPF program crate local tests into workspace global test directory#1708
Merged
Lichtso merged 3 commits intoanza-xyz:masterfrom Jun 12, 2024
Conversation
dmakarov
approved these changes
Jun 12, 2024
samkim-crypto
pushed a commit
to samkim-crypto/agave
that referenced
this pull request
Jul 31, 2024
…test directory (anza-xyz#1708) * Splits SBPF program test crate `mem` into `dep`. * Moves crate local tests into workspace global test directory. * Removes non-dev dependencies from Cargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is split off from #1581.
Problem
Currently some SBPF program test crates have their own
tests/directory. This causes these crates to be build as bin for the guest and as lib for the host, additionally to the host test files.In a workspace one can only inherit
workspace.dependencieswith no global distinction betweendependenciesanddev-dependencies, that happens in each crate individually. These tests are to be hoisted to the workspace global tests directory to allow us to separate the build targets workspace wide. Also, all other program tests are already there so this is more consistent.Summary of Changes
memandmem-dep(like Refactor - Splits SBPF program test crates intodeps to remove cfg featureprogram#1687)dependenciesinto the workspace globaldev-dependenciesdev-dependenciesinto the workspace globaldev-dependencies