Skip to content

Refactor - Move SBPF program crate local tests into workspace global test directory#1708

Merged
Lichtso merged 3 commits intoanza-xyz:masterfrom
Lichtso:refactor/move_spbf_program_tests_directory
Jun 12, 2024
Merged

Refactor - Move SBPF program crate local tests into workspace global test directory#1708
Lichtso merged 3 commits intoanza-xyz:masterfrom
Lichtso:refactor/move_spbf_program_tests_directory

Conversation

@Lichtso
Copy link
Copy Markdown

@Lichtso Lichtso commented Jun 12, 2024

This PR is split off from #1581.

Problem

Currently some SBPF program test crates have their own tests/ directory. This causes these crates to be build as bin for the guest and as lib for the host, additionally to the host test files.

In a workspace one can only inherit workspace.dependencies with no global distinction between dependencies and dev-dependencies, that happens in each crate individually. These tests are to be hoisted to the workspace global tests directory to allow us to separate the build targets workspace wide. Also, all other program tests are already there so this is more consistent.

Summary of Changes

  • Splits mem and mem-dep (like Refactor - Splits SBPF program test crates into deps to remove cfg feature program #1687)
  • Moves the workspace global dependencies into the workspace global dev-dependencies
  • Moves the crate local dev-dependencies into the workspace global dev-dependencies
  • Moves the following crate local tests into the workspace global tests directory:
    • "mem"
    • "remaining-compute-units"
    • "sanity"
    • "simulation"
    • "simulation_validator"
    • "sysvar"

@Lichtso Lichtso requested a review from pgarg66 June 12, 2024 19:00
@Lichtso Lichtso merged commit 06f1131 into anza-xyz:master Jun 12, 2024
@Lichtso Lichtso deleted the refactor/move_spbf_program_tests_directory branch June 12, 2024 19:36
samkim-crypto pushed a commit to samkim-crypto/agave that referenced this pull request Jul 31, 2024
…test directory (anza-xyz#1708)

* Splits SBPF program test crate `mem` into `dep`.

* Moves crate local tests into workspace global test directory.

* Removes non-dev dependencies from Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants