Refactor - Splits SBPF program test crates into deps to remove cfg feature program#1687
Merged
Lichtso merged 1 commit intoanza-xyz:masterfrom Jun 12, 2024
Conversation
49ce3ca to
f9475fa
Compare
f9475fa to
cd39bfa
Compare
dmakarov
approved these changes
Jun 12, 2024
samkim-crypto
pushed a commit
to samkim-crypto/agave
that referenced
this pull request
Jul 31, 2024
…feature `program` (anza-xyz#1687) Splits crates into "dep"s to remove cfg feature "program".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is split off from #1581.
Problem
We want to use the normal cargo workspace build procedure instead of using a build.rs script.
Currently some test program crates export a part of their interface to others (for CPI) and to do so they utilize a cfg feature
program. That cfg feature toggles if the crate is build as a dependency / lib for another crate or as a standalone test program. However, with workspaces that won't work anymore because in a workspace each crate can only be build with one feature set. Additionally, some program test crates are already split into adepcrate, so it is currently somewhat inconsistent.Summary of Changes
Splits the following into a separate
depcrate each:For each this:
programcfg featureAlso cleans up the following without splitting (as they were never used as dependencies elsewhere):