v4.0: Ignores ancestors in snapshot (backport of #10835)#10990
Merged
Conversation
(cherry picked from commit d42c653)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4.0 #10990 +/- ##
=========================================
- Coverage 83.0% 83.0% -0.1%
=========================================
Files 836 836
Lines 316382 316380 -2
=========================================
- Hits 262780 262738 -42
- Misses 53602 53642 +40 🚀 New features to boost your workflow:
|
roryharr
approved these changes
Mar 4, 2026
steviez
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Loading from a snapshot doesn't require reading the ancestors.
Summary of Changes
Ignore 'em.
Justification to Backport
This one isn't a big deal, no, and we don't need to backport it. But it does impact other snapshot changes I'm making due to how frozen abi stuff works. There are other PRs after this one that I intend to backport to v4.0 as well. By backporting this one, and all the subsequent ones, and doing them all in order, that ensures each one will have a clean diff. Otherwise the frozen abi digest will differ each time, requiring manual intervention.
This is an automatic backport of pull request #10835 done by [Mergify](https://mergify.com).