Skip to content

Ignores ancestors in snapshot#10835

Merged
brooksprumo merged 1 commit into
anza-xyz:masterfrom
brooksprumo:snap/ancestors
Feb 26, 2026
Merged

Ignores ancestors in snapshot#10835
brooksprumo merged 1 commit into
anza-xyz:masterfrom
brooksprumo:snap/ancestors

Conversation

@brooksprumo
Copy link
Copy Markdown

@brooksprumo brooksprumo commented Feb 25, 2026

Problem

Loading from a snapshot doesn't require reading the ancestors.

Summary of Changes

Ignore 'em.

@brooksprumo brooksprumo self-assigned this Feb 25, 2026
@brooksprumo brooksprumo force-pushed the snap/ancestors branch 2 times, most recently from 2a0e158 to 8d511ba Compare February 25, 2026 20:37
Comment thread runtime/src/bank/serde_snapshot.rs Outdated
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.0%. Comparing base (f372294) to head (adcd705).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #10835     +/-   ##
=========================================
- Coverage    83.0%    83.0%   -0.1%     
=========================================
  Files         836      836             
  Lines      316307   316305      -2     
=========================================
- Hits       262640   262637      -3     
- Misses      53667    53668      +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

roryharr
roryharr previously approved these changes Feb 26, 2026
feature = "frozen-abi",
derive(AbiExample),
frozen_abi(digest = "FCDuswxZnGvvJURSkrQPshX45a25CR6UAmPgzGeUfMFv")
frozen_abi(digest = "HKTVanoy2iLbtAVwrt2y8HxH8YaWsgw4LZC9B76X6EL4")
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Digest changed because we renamed the field. No actual ABI change.

--- bank__serde_snapshot__tests__test_bank_serialize__BankAbiTestWrapper_frozen_abi__test_api_digest_FCDuswxZnGvvJURSkrQPshX45a25CR6UAmPgzGeUfMFv	2026-02-26 16:57:31
+++ bank__serde_snapshot__tests__test_bank_serialize__BankAbiTestWrapper_frozen_abi__test_api_digest_HKTVanoy2iLbtAVwrt2y8HxH8YaWsgw4LZC9B76X6EL4	2026-02-26 16:56:06
@@ -158,7 +158,7 @@
                                                 primitive u64
                             field max_age: usize
                                 primitive u64
-                    field ancestors: std::collections::hash::map::HashMap<u64, usize>
+                    field unused_ancestors: std::collections::hash::map::HashMap<u64, usize>
                         map (entries = 1)
                             key u64
                                 primitive u64

@brooksprumo
Copy link
Copy Markdown
Author

Needed to rebase due to frozen abi digest after merging #10852.

@brooksprumo brooksprumo added this pull request to the merge queue Feb 26, 2026
Merged via the queue into anza-xyz:master with commit d42c653 Feb 26, 2026
51 checks passed
@brooksprumo brooksprumo deleted the snap/ancestors branch February 26, 2026 23:29
@brooksprumo brooksprumo added the v4.0 Backport to v4.0 branch label Mar 4, 2026
@mergify
Copy link
Copy Markdown

mergify Bot commented Mar 4, 2026

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify Bot pushed a commit that referenced this pull request Mar 4, 2026
brooksprumo added a commit that referenced this pull request Mar 4, 2026
Ignores ancestors in snapshot (#10835)

(cherry picked from commit d42c653)

Co-authored-by: Brooks <brooks@anza.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4.0 Backport to v4.0 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants