feat: op-reth

[clabby]

Overview

This PR contains the full diff for op-geth compared against main, which will be kept up to date with upstream during the development process.

All op-reth related PRs will go into this branch, and once it is ready to upstream, we'll change the destination branch to paradigmxyz/reth/main.

Resources

• op-geth diff
• forkdiff page hosted at op-reth.anton.systems based on op-reth-diff.

Notes for Reviewers and Reviewing

• Double check that penalization for deposit transaction broadcasts through tx pool is ok. see @rkrasiuk's comment feat(transaction-pool): Tx Pool Cost Updates #65 (comment)
• Add lots of comments - especially for the unclear stuff
• make the diff very maintainable
• feat: op-reth #8 (comment) : crates/revm/src/executor.rs is a very sensitive file - needs thorough review
• Verify revm executor changes are acceptable with upstream changes. See (resolved) conversation here

All Future Issues (tracking)

• Add tests for the deposit transaction rpc sending (see internal/ethapi/api_test.go)
• feat(op-reth): Match the RPC changes in the LES RPC paradigmxyz/reth#4218
• feat(op-reth): Tracer RPC daisy-chain paradigmxyz/reth#4217
• feat(op-reth): Priority Fee Suggestion paradigmxyz/reth#4216
• feat(op-reth): Support Snap Sync if Available Post-Bedrock paradigmxyz/reth#4209
• feat(op-reth): Add Shanghai Hardfork to Optimism ChainSpecs [PLANNED] paradigmxyz/reth#4214
• feat(op-reth): Add Cancun Hardfork to the Optimism Chainspec [PLANNED] paradigmxyz/reth#4213
• DB migration tool: https://github.com/clabby/op-reth

op-geth mappings

The below toggles contain mappings of all op-geth diff changes to their respective places in op-reth.

(if you have questions on this stuff ask @refcell - wrote all these toggles out)

✅ op-geth Diff Mapping: Core Modifications +901 | -52

• State-transition modifications +494 | -16
  • Deposit Transaction type +191 | -0
    • core/types/deposit_tx.go +96 | -0
    • core/types/transaction_marshalling.go +81 | -0
    • core/types/transaction_signing.go +14 | -0
  • Transaction properties +83 | -0
    • core/types/transaction.go +80 | -0
    • core/types/tx_access_list.go +1 | -0
    • core/types/tx_dynamic_fee.go +1 | -0
    • core/types/tx_legacy.go +1 | -0
  • L1 cost computation +103 | -5
    • core/vm/evm.go +5 | -1
    • core/types/rollup_l1_cost.go +83 | -0
    • core/state_processor.go +14 | -3
    • core/state_prefetcher.go +1 | -1
  • Transaction processing +110 | -9
    • core/state_transition.go +110 | -9
  • Gaslimit +4 | -2
    • consensus/misc/eip1559.go +4 | -2
  • Consensus tweaks +3 | -0
    • consensus/beacon/consensus.go +3 | -0
• Chain config +118 | -1
  • params/config.go +80 | -0
  • params/protocol_params.go +12 -1 (this will be accounted for in the revm cost function)
  • core/genesis.go +26 | -0
• Chain config cleanup +3 | -0
  • core/rawdb/accessors_metadata.go +3 | -0 (not included since we don't have clique consensus)
• Engine API modifications +58 | -4
  • beacon/engine/types.go +12 | -1
  • beacon/engine/gen_blockparams.go +28 | -2
  • eth/catalyst/api.go +18 | -1
• Block-building modifications +105 | -12
  • miner/payload_building.go +22 | -2
  • miner/worker_test.go +4 | -3
  • miner/miner.go +8 | -0
  • miner/worker.go +71 | -7
• Tx-pool tx cost updates +123 | -19
  • core/txpool/txpool.go +93 | -12
  • core/txpool/list.go +9 | -0
  • core/txpool/txpool_test.go +21 | -7

✅ op-geth Diff Mapping: Node modifications +158 | -10

• CLI +124 | -8
  • Flags +95 | -3
    • cmd/utils/flags.go +72 | -3
    • cmd/geth/main.go +9 | -0
    • internal/flags/categories.go +1 | -0
    • cmd/geth/config.go +13 | -0
  • Versioning +29 | -5
    • cmd/geth/misccmd.go +1 | -0
    • params/version.go +27 | -4
    • build/ci.go +1 | -1
• Node config +10 | -0
  • eth/ethconfig/config.go +10 | -0
• Tx gossip disable option +24 | -2
  • eth/handler.go +7 | -1
  • eth/handler_eth.go +17 | -1

✅ op-geth Diff Mapping: User API enhancements +995 | -63

• Receipts metadata +223 | -6
  • core/types/receipt.go +195 | -6
  • core/types/gen_receipt_json.go +28 | -0
• API Backend +89 | -8
  • eth/api_backend.go +35 | -6
  • eth/backend.go +52 | -2
  • internal/ethapi/backend.go +2 | -0
• Apply L1 cost in API responses +1 | -1
  • eth/state_accessor.go +1 | -1
• API frontend +235 | -14
  • internal/ethapi/api.go +225 | -14
  • rpc/errors.go +10 | -0
• Tracer RPC daisy-chain +59 | -12 OUT OF SCOPE
  • eth/tracers/api.go +59 | -12
• Light Ethereum Subprotocol (LES) RPC +37 | -4 OUT OF SCOPE
  • les/state_accessor.go +1 | -1
  • les/api_backend.go +9 | -1
  • les/odr_test.go +2 | -2
  • les/client.go +25 | -0
• Daisy Chain tests +351 | -18 OUT OF SCOPE
  • internal/ethapi/transaction_args_test.go +3 | -1
  • ethclient/ethclient_test.go +152 | -7
  • eth/tracers/api_test.go +196 | -10

✅ op-geth Diff Mapping: Geth extras (not mapped 1:1 since we will have "reth extras") +325 | -25

• Simulated Backend +90 | -19
  • accounts/abi/bind/backends/simulated.go +90 | -19
• diff-included testing testing +235 | -6
  • core/types/transaction_marshalling_test.go +103 | -0
  • internal/ethapi/api_test.go +132 | -6

✅ op-geth Diff Mapping: Other changes +690 | -16

• cmd/devp2p/internal/ethtest/snap.go +2 | -2
• core/blockchain.go +4 | -0
• core/blockchain_reader.go +8 | -0
• core/error.go +3 | -0
• core/evm.go +3 | -1
• core/rawdb/accessors_chain.go +12 | -5
• core/rawdb/accessors_chain_test.go +41 | -1
• core/types/receipt_test.go +281 | -1
• core/types/rollup_l1_cost_test.go +30 | -0
• core/types/tx_blob.go +1 | -0
• eth/api.go +7 | -1
• eth/gasprice/gasprice.go +23 | -1( Part of Priority fee suggestion)
• eth/gasprice/optimism-gasprice.go +110 | -0 ( Part of Priority fee suggestion)
• eth/gasprice/optimism-gasprice_test.go +142 | -0 ( Part of Priority fee suggestion)
• eth/protocols/snap/handler.go +1 | -1
• light/odr_test.go +1 | -1
• params/config_test.go +19 | -0
• tests/state_test.go +1 | -1
• tests/state_test_util.go +1 | -1

[refcell]

LGTM

[refcell]

PR is opened upstream now @ paradigmxyz#4377. Closing this for now unless needed.