Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

feat(preimage/common): Migrate to thiserror#543

Merged
clabby merged 1 commit intomainfrom
cl/preimage-error-conversion
Sep 21, 2024
Merged

feat(preimage/common): Migrate to thiserror#543
clabby merged 1 commit intomainfrom
cl/preimage-error-conversion

Conversation

@clabby
Copy link
Contributor

@clabby clabby commented Sep 21, 2024

Overview

Migrates kona-preimage & kona-common to thiserror.

Copy link
Contributor Author

clabby commented Sep 21, 2024

@codecov
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 76.59574% with 11 lines in your changes missing coverage. Please review.

Project coverage is 78.0%. Comparing base (9db7ced) to head (6b32a3d).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/common/src/linux.rs 0.0% 5 Missing ⚠️
crates/preimage/src/errors.rs 0.0% 2 Missing ⚠️
crates/preimage/src/oracle.rs 83.3% 2 Missing ⚠️
crates/common/src/errors.rs 0.0% 1 Missing ⚠️
crates/preimage/src/key.rs 66.6% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clabby clabby force-pushed the cl/preimage-error-conversion branch from 2c44dbd to 6b32a3d Compare September 21, 2024 21:29
@clabby clabby changed the base branch from cl/mpt-error-conversion to main September 21, 2024 21:29
@clabby clabby enabled auto-merge September 21, 2024 21:29
@clabby clabby added this pull request to the merge queue Sep 21, 2024
Merged via the queue into main with commit abbbc88 Sep 21, 2024
@github-actions github-actions bot mentioned this pull request Sep 21, 2024
@clabby clabby deleted the cl/preimage-error-conversion branch September 21, 2024 22:49
This was referenced Sep 21, 2024
This was referenced Oct 13, 2024
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Dec 10, 2025
theochap pushed a commit to ethereum-optimism/optimism that referenced this pull request Jan 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-providers Area: provider crates K-feature Kind: feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants