Skip to content

Avoid dynamic_cast<> if we already know the type #3610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hzeller wants to merge 1 commit into from
Closed

Avoid dynamic_cast<> if we already know the type #3610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions runtime/Cpp/runtime/src/ParserRuleContext.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
/* Copyright (c) 2012-2017 The ANTLR Project. All rights reserved.
/* Copyright (c) 2012-2017 The ANTLR Project. All rights reserved.
Copy link
Contributor Author

@hzeller hzeller Mar 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: This is the superfluous and Byte Order Mark, that was removed while editing. This is UTF-8, not UTF-16.

* Use of this file is governed by the BSD 3-clause license that
* can be found in the LICENSE.txt file in the project root.
*/

#pragma once

#include "RuleContext.h"
#include "support/Casts.h"
#include "support/CPPUtils.h"

namespace antlr4 {
Expand Down Expand Up @@ -102,9 +103,9 @@ namespace antlr4 {

size_t j = 0; // what element have we found with ctxType?
for (auto &child : children) {
if (antlrcpp::is<T *>(child)) {
if (antlrcpp::is<T *>(child)) { // TODO: avoid slow is<> call.
if (j++ == i) {
return dynamic_cast<T *>(child);
return antlrcpp::downCast<T *>(child);
}
}
}
Expand All @@ -115,8 +116,8 @@ namespace antlr4 {
std::vector<T *> getRuleContexts() {
std::vector<T *> contexts;
for (auto *child : children) {
if (antlrcpp::is<T *>(child)) {
contexts.push_back(dynamic_cast<T *>(child));
if (antlrcpp::is<T *>(child)) { // TODO: avoid slow is<> call
contexts.push_back(antlrcpp::downCast<T *>(child));
}
}

Expand Down