Avoid dynamic_cast<> if we already know the type#3610
Closed
Avoid dynamic_cast<> if we already know the type#3610
Conversation
In that case, downCast() is sufficient. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
20220329-avoid-dynamic-cast-when-knowing-type
branch
from
abadea8 to
08a3933
Compare
hzeller
commented
Mar 30, 2022
| @@ -1,11 +1,12 @@ | |||
| /* Copyright (c) 2012-2017 The ANTLR Project. All rights reserved. | |||
| /* Copyright (c) 2012-2017 The ANTLR Project. All rights reserved. | |||
Contributor
Author
There was a problem hiding this comment.
FYI: This is the superfluous and Byte Order Mark, that was removed while editing. This is UTF-8, not UTF-16.
Contributor
Author
|
This will be covered by #3612, closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In that case, downCast() is sufficient.