Add setting_sources input and default base-action to user-only#1115
Open
km-anthropic wants to merge 6 commits into
Open
Add setting_sources input and default base-action to user-only#1115km-anthropic wants to merge 6 commits into
km-anthropic wants to merge 6 commits into
Claude / Claude Code Review
completed
Apr 23, 2026 in 5m 31s
Code review found 1 important issue
Found 6 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | src/entrypoints/run.ts:284-289 |
Wrapper regression: @claude on plain issues drops project/local settings |
Annotations
Check failure on line 289 in src/entrypoints/run.ts
claude / Claude Code Review
Wrapper regression: @claude on plain issues drops project/local settings
This regresses the common "@claude on a plain issue" flow: `issue_comment` on a non-PR issue has `context.isPR === false`, so `configRestoredFromBase` stays false, `defaultSettingSources` is left undefined, and `parseSdkOptions` applies the event-gated default of `['user']` — silently dropping `.claude/settings.json` and `.mcp.json` that loaded before this PR. The checkout there is the trusted default branch (and the `issues` event still gets `project,local`), so the restriction isn't security-m
Loading