-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add setting_sources input and default base-action to user-only #1115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
km-anthropic
wants to merge
1
commit into
main
Choose a base branch
from
setting-sources-default
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+78
−7
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 The main action sets
default: "user,project,local"forsetting_sources, which GitHub Actions always resolves even when the user omits the input. This makesoptions.settingSourcesalways truthy inparseSdkOptions, so--setting-sourcespassed viaclaude_argsis silently ignored for main action users. Any workflow previously usingclaude_args: "--setting-sources user"to restrict sources will now silently getuser,project,localinstead.Extended reasoning...
What the bug is
The new
setting_sourcesinput inaction.yml(line 65-68) hasdefault: "user,project,local". In GitHub Actions, when an input has a non-empty default and the user does not explicitly provide that input, GitHub resolves it to the default value. This meansINPUT_SETTING_SOURCESis always set to"user,project,local"for every main action user who does not explicitly setsetting_sources.The code path
In
parseSdkOptions(line 257-262), the precedence chain is:options.settingSources— fromINPUT_SETTING_SOURCES(always"user,project,local"for main action)extraArgs["setting-sources"]— parsed fromclaude_args["user"]Since
options.settingSourcesis always truthy for the main action, theextraArgs["setting-sources"]branch is dead code. The fallback fromclaude_argsis unreachable.Step-by-step proof
Consider a workflow that previously worked:
setting_sourcesinput explicitly.inputs.setting_sourcesto"user,project,local"(the default).action.ymlpassesINPUT_SETTING_SOURCES: ${{ inputs.setting_sources }}→"user,project,local".run.tspassessettingSources: process.env.INPUT_SETTING_SOURCES→"user,project,local".parseSdkOptions,options.settingSourcesis"user,project,local"(truthy), so the first branch is taken.--setting-sources userfromclaude_argsis parsed intoextraArgs["setting-sources"]but never checked.settingSources = ["user", "project", "local"]instead of the intended["user"].Why existing code doesn't prevent it
The precedence logic in
parseSdkOptionsis correct in isolation — it properly prioritizes direct input overclaude_args. The problem is that GitHub Actions conflates "user provided a value" with "default was applied". The base-action avoids this by usingdefault: "", which is falsy. The main action uses a non-empty default, making it indistinguishable from an explicit user input.Impact
Any main action user who previously used
claude_args: "--setting-sources user"to restrict setting sources (e.g., to avoid in-repo.claude/settings.jsonexpanding their allowlist) will have that restriction silently removed. The PR description explicitly states "Verified existing--setting-sourcesusers viaclaude_argsare unaffected," which is only true for the base-action.How to fix
Either make the main action's default empty (like the base-action) and apply the permissive default
["user", "project", "local"]inrun.tsbefore callingrunClaude(only whenINPUT_SETTING_SOURCESis empty/unset), or document this as a breaking change for users who relied onclaude_argsto override setting sources.