Skip to content
This repository has been archived by the owner on Aug 26, 2024. It is now read-only.

Remove molecule-docker plugin from creator-ee #65

Merged
merged 1 commit into from
May 19, 2022

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented May 19, 2022

This change is needed because community.docker collections has
a requirements on python package docker-compose<2.0 and that is
causing other conflicts with our dependencies. As new docker-compose
versions are no longer on pypi, the only workaround would for the
collection to make that dependency soft.

This will not be added back unless that conflicts are addressed.

That was blocking ansible-lint version upgrade inside the container, as seen on #62

@ssbarnea ssbarnea requested a review from a team as a code owner May 19, 2022 09:42
@ssbarnea ssbarnea added the major label May 19, 2022
This change is needed because community.docker collections has
a requirements on python package docker-compose<2.0 and that is
causing other conflicts with our dependencies. As new docker-compose
versions are no longer on pypi, the only workaround would for the
collection to make that dependency soft.

This will not be added back unless that conflicts are addressed.
@ssbarnea ssbarnea merged commit 10d69e8 into ansible:main May 19, 2022
@ssbarnea ssbarnea deleted the fix/check branch May 19, 2022 11:20
ssbarnea added a commit to ssbarnea/creator-ee that referenced this pull request May 20, 2022
That change finishes ansible#65 and removes any docker use from our
container.
ssbarnea added a commit that referenced this pull request May 20, 2022
That change finishes #65 and removes any docker use from our
container.
@jtrutwin
Copy link

Well this is a bummer.... Do you think it'll ever come back?
I was hoping to use this to test molecule builds that used the docker driver.

@ssbarnea
Copy link
Member Author

ssbarnea commented May 20, 2022

@jtrutwin If you want to get it back sooner, I would suggest getting started on making required changes to community.docker collection and getting rid of docker-compose python package dependency. That was the root cause.

Another alternative would be to convince https://github.com/docker/compose team to make another release of v1 that is not rigged with timebombs such https://github.com/docker/compose/blob/master/setup.py#L28-L37 but I kinda have the feeling that the success rate would be low.

As you can see they have jsonschema<4, guess what kind of requirement we have for linter... ;)

@felixfontein
Copy link

You could also run pip install . for a dictory containing setup.py containing something like

try:
    from setuptools import setup
except ImportError:
    from distutils.core import setup

text_1 = 'Fake docker-compose package to prevent installation of docker-compose from Python requirements.'
text_2 = 'Use `pip install --force docker-compose` to install the real docker-compose.'

setup(
    name='docker-compose',
    version='0.0.0',
    description='%s %s' % (text_1, text_2),
    long_description='# %s\n\n%s' % (text_1, text_2),
    author='Felix Fontein',
    author_email='[email protected]',
    license='GPL-3.0-or-later',
    classifiers=['Development Status :: 1 - Planning'],
    packages=[],
    package_dir={},
)

in additional_build_steps.prepend. It would also help a lot if EEs would be a bit more flexible and could make dependencies optional.

@jtrutwin
Copy link

Thanks, yes I was able to get around using pip3 install docker and the community.docker ansible galaxy collection.

Now unfortunately I'm hitting this issue: #19

@ssbarnea thanks for the details - I'm REALLY new to all this stuff so I'll be of little use to getting anything accomplished in the docker community - thanks for your work on this project.

@gardar
Copy link

gardar commented Jun 3, 2022

Any chance molecule-containers could be re-added, even though docker has been removed?
I like to use molecule-containers in my roles so that I don't have to specify a driver explicitly.

@ssbarnea
Copy link
Member Author

ssbarnea commented Jun 6, 2022

@gardar Nope, basically because molecule-containers relies on docker one. Once the collection is fixed we will likely add it back.

@gardar
Copy link

gardar commented Jun 7, 2022

Hum, didn't realize you'd need to have both installed to be able to use molecule-containers... Sounds like it's kind of defeating the purpose of molecule-containers then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants