Remove docker-compose from python dependencies #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this module is unmaintained and is creating conflicts with other packages, we need to remove it in order to still be able to use the rest of the collection. In a follow-up we should migrate our docker_compose module to use docker compose cli, so it would work with v2 of it.
Docs Build 📝This PR is closed and any previously published docsite has been unpublished. |
felixfontein
added
the
breaking_change
felixfontein
requested changes
May 20, 2022
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| namespace: community | |||
| name: docker | |||
| version: 2.6.0 | |||
| version: 3.0.0-alpha.0 | |||
There was a problem hiding this comment.
This must be removed from this PR. Release-related changes are not part of regular PRs.
| @@ -1,2 +1,3 @@ | |||
| docker | |||
| docker-compose | |||
| # do not add docker-compose python package as a depedency as the module | |||
| # is unmaintained and it is now a go project and called by docker directly. | |||
There was a problem hiding this comment.
This needs a) a changelog fragment, and b) a second PR with a deprecation changelog fragment (to be merged and released soon). This one can only be merged once we start preparing 3.0.0 (which isn't planned right now at all).
There was a problem hiding this comment.
Meanwhile I removed this collection from creator-ee.
|
Deprecation in #373. |
|
Superseded by #400. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As this module is unmaintained and is creating conflicts with other packages, we need to remove it in order to still be able to use the rest of the collection. In a follow-up we should migrate our docker_compose module to use docker compose cli, so it would work with v2 of it.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
This issue with community.docker is blocking integration of newer ansible-lint into creator-ee, and devtools team will remove community.docker and molecule-docker plugin from this container until that is addressed.
References: