fix: github action ref doesn't checkout that ref #4774
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The below code block will checkout ansible-lint at main. Proof:
Using ansible-lint ref: main
will show up in the GHA (see "Was" section of verification below). Expected: it should checkout ansible-lint atv25.8.2
.Explanation
This is believed to be because of a long-standing bug for github variables in a composite action (see below linked issues), which this
action.yml
seems to be. Given that root bug hasn't been fixed since 2023, it effectively becomes a bug manifested in ansible-lint.GITHUB_ACTION_REF
andGITHUB_ACTION_REPOSITORY
actions/runner#2525github.action_repository
andgithub.action_ref
are empty inrun
for composite actions actions/runner#2473Following a similar example to actions/runner#2525 , I have renamed that variable so it gets around the bug in GHAs.
Verification
Was:
main
despite specifying the tag to use (see top line of image).Is: