github.action_repository and github.action_ref are empty in run for composite actions
#2473
Comments
|
Accidentally duplicated with #2525 😅 Leaving it open for now in case there is other useful info in it. 🤷🏻 |
|
Seems like there has been an update to the support ticket: github/docs#25336. I'm linking it here to connect those issues, however the response quoted in the linked docs issue reads like won't fix. |
|
Am I missing something or this means that is impossible to use a specific version of the action due to this bug? |
|
No, your action will still run, you just won't easily know where your action came from and what version you are. If you burn that info into your repo w/ files, you could get info that way. And iirc I had some way to work around this, it's just fairly annoying. |
|
We use dynamic versioning based on github tags, so basically is impossible for the code to discover its own version and tell user to upgrade if needed, code that we already had implemented for normal usage. Is bit perplexed by the fact that that all that happens seems more like on-purpose to make it impossible to know:
|
|
Yes, I sympathize -- that's why I filed this. Fwiw, there is a workaround noted in github/docs#25336 (comment) (I think @ChristopherHX might have suggested it somewhere), and it looks like they're going to document this quirk in the near future. Basically my |
|
Yeah I mentioned this in https://github.com/orgs/community/discussions/49245#discussioncomment-5209064. Keep in mind local action call syntax (./) doesn't have an action_ref, that's why most action ci will have empty values if using it for tests... A similar problems happens by using It's totally unsafe to use composite actions are quite buggy and some very old issues about them are not fixed within 1 year, even if a pr has been contributed |
|
Right, which means this is how I worked around it: It's good enough for testing... |
|
it seems that the workaround doesnt work for embedded composite actions, it seems that it shows the top level action ref always. following code in the run: |
echo "action_ref: $action_ref"
env:
action_ref: ${{ github.action_ref }} |
|
Thanks for letting me know that my initial workaround is affected by another actions/runner bug..., if we nest composite actions (Sadly local composite actions break all post steps inputs) inputs:
action_ref:
default: ${{ github.action_ref }} # Downside the user can override it
runs:
using: composite
steps:
- uses: actions/github-script@v5
with:
script: |
console.log('${{ github.action_ref }}'); # broken, returns v5
- run: echo ${{ env.ref }}
env:
ref: ${{ github.action_ref }} # broken
shell: bash
- run: echo ${{ env.ref }}
env:
ref: ${{ inputs.action_ref }} # works
shell: bash
- run: echo ${{ inputs.action_ref }} # works
shell: bashExpected log outputTo recap you could try the following ( verified locally using actions runner 2.309.0 ) inputs:
action_ref:
default: ${{ github.action_ref }}
runs:
using: composite
steps:
- run: echo ${{ inputs.action_ref }}
shell: bash |
Thanks for the prompt reply, with inputs default value, it's working now, this is really tricky :) |
|
Any update on this? We seem to have also just hit this problem, still seems to be an issue |
To reference metadata about composite actions, GitHub Actions provides the `github.action_` context, including `github.action_path`, `github.action_ref`, and `github.action_repository`. GitHub Actions supports nested composite actions with a recursion limit of 9 (9 nested composite actions). Unfortunately `github.action_` values are not propagated correctly when running nested composite actions. This is a bug in the GitHub Actions runner. The suggested workaround is to use inputs to set the correct values. This commit will implement the suggested workaround. https://docs.github.com/en/actions/creating-actions/creating-a-composite-action https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#github-context actions/runner#2473 (comment) pypa#299
To reference metadata about composite actions, GitHub Actions provides the `github.action_` context, including `github.action_path`, `github.action_ref`, and `github.action_repository`. GitHub Actions supports nested composite actions with a recursion limit of 9 (9 nested composite actions). Unfortunately `github.action_` values are not propagated correctly when running nested composite actions. This is a bug in the GitHub Actions runner. The suggested workaround is to use inputs to set the correct values. This commit will implement the suggested workaround. https://docs.github.com/en/actions/creating-actions/creating-a-composite-action https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#github-context actions/runner#2473 (comment) pypa#299
To reference metadata about composite actions, GitHub Actions provides the `github.action_` context, including `github.action_path`, `github.action_ref`, and `github.action_repository`. GitHub Actions supports nested composite actions with a recursion limit of 9 (9 nested composite actions). Unfortunately `github.action_` values are not propagated correctly when running nested composite actions. This is a bug in the GitHub Actions runner. The suggested workaround is to use inputs to set the correct values. This commit will implement the suggested workaround. https://docs.github.com/en/actions/creating-actions/creating-a-composite-action https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#github-context actions/runner#2473 (comment) pypa#299
To reference metadata about composite actions, GitHub Actions provides the `github.action_` context, including `github.action_path`, `github.action_ref`, and `github.action_repository`. GitHub Actions supports nested composite actions with a recursion limit of 9 (9 nested composite actions). Unfortunately `github.action_` values are not propagated correctly when running nested composite actions. This is a bug in the GitHub Actions runner. The suggested workaround is to use inputs to set the correct values. This commit will implement the suggested workaround. https://docs.github.com/en/actions/creating-actions/creating-a-composite-action https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#github-context actions/runner#2473 (comment) pypa#299
To reference metadata about composite actions, GitHub Actions provides the `github.action_` context, including `github.action_path`, `github.action_ref`, and `github.action_repository`. GitHub Actions supports nested composite actions with a recursion limit of 9 (9 nested composite actions). Unfortunately `github.action_` values are not propagated correctly when running nested composite actions. This is a bug in the GitHub Actions runner. The suggested workaround is to use inputs to set the correct values. This commit will implement the suggested workaround. https://docs.github.com/en/actions/creating-actions/creating-a-composite-action https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#github-context actions/runner#2473 (comment) pypa#299
To reference metadata about composite actions, GitHub Actions provides the `github.action_` context, including `github.action_path`, `github.action_ref`, and `github.action_repository`. GitHub Actions supports nested composite actions with a recursion limit of 9 (9 nested composite actions). Unfortunately `github.action_` values are not propagated correctly when running nested composite actions. This is a bug in the GitHub Actions runner. The suggested workaround is to use inputs to set the correct values. This commit will implement the suggested workaround. https://docs.github.com/en/actions/creating-actions/creating-a-composite-action https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#github-context actions/runner#2473 (comment) pypa#299
and others
Describe the bug
github.action_repositoryandgithub.action_refare empty inrunfor composite actionsTo Reproduce
github.action_repository/github.action_refinrunin a step.Expected behavior
github.action_repository/github.action_refshould be filled in forrunjust as it is forenvRunner Version and Platform
Version of your runner?
Current runner version: '2.302.1'
OS of the machine running the runner? ubuntu-latest
What's not working?
github.action_repository/github.action_refare emptyJob Log Output
https://github.com/check-spelling/gotosocial/actions/runs/4337164095/jobs/7572980729
Runner and Worker's Diagnostic Logs
If applicable, add relevant diagnostic log information. Logs are located in the runner's
_diagfolder. The runner logs are prefixed withRunner_and the worker logs are prefixed withWorker_. Each job run correlates to a worker log. All sensitive information should already be masked out, but please double-check before pasting here.The text was updated successfully, but these errors were encountered: