This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Add RDP login support for windows hosts#36
Merged
ssbarnea merged 2 commits intoansible-community:masterfrom Feb 22, 2021
troyready:add_rdp_login
Merged
Add RDP login support for windows hosts#36ssbarnea merged 2 commits intoansible-community:masterfrom troyready:add_rdp_login
ssbarnea merged 2 commits intoansible-community:masterfrom
troyready:add_rdp_login
Conversation
Collaborator
|
Hi @troyready |
Contributor
Author
|
Sure thing @tbugfinder . I ran pre-commit to fix the linting, and the test issues look to be unrelated (e.g. a bunch of |
Collaborator
|
Those |
Collaborator
|
Hi @troyready |
Current login command is hardcoded to SSH for all hosts. This enhancement adds a check for WinRM use, and for those hosts uses xfreerdp to open an RDP session instead.
ssbarnea
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current login command is hardcoded to SSH for all hosts. This enhancement adds a check for WinRM use, and for those hosts uses xfreerdp to open an RDP session instead.