This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Fix #33 filter molecule_header, header or molecule_from_yaml missing#34
Merged
ssbarnea merged 3 commits intoansible-community:masterfrom Feb 21, 2021
Merged
Conversation
|
+1 for this commit |
ssbarnea
suggested changes
Jan 20, 2021
Member
ssbarnea
left a comment
ssbarnea
left a comment
There was a problem hiding this comment.
This review is not complete as it needs other changes, like adding sh module dependency or replacing it.
Ping me on irc when ready.
Collaborator
|
Hi @aruntomar , |
Contributor
Author
|
hi @tbugfinder, apologies for the delay. lately, I have been distracted and haven't focused. I'll try to fix it this weekend. Arun |
…t file and use that file in tox.ini
Contributor
Author
|
@tbugfinder @ssbarnea All checks passing now. kindly review. |
ssbarnea
approved these changes
Feb 21, 2021
jonashackt
added a commit
to jonashackt/molecule-ansible-docker-aws
that referenced
this pull request
Feb 24, 2021
…dencies accordingly. But we have errors, see https://github.com/ansible-community/molecule/discussions/2946, https://github.com/ansible-community/molecule/pull/2869/files, ansible-community/molecule-ec2#34 (only merged 3 days ago). Also removed CircleCI for now, since the goal is to simply run every scenario on GHA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #33
As of molecule v3, ansible molecule filters have been removed.