vmware_guest: Fix disk parameter validation #705
Conversation
ansibullbot
added
bug
| @@ -2477,7 +2477,7 @@ def sanitize_disk_parameters(self, vm_obj): | |||
| """ | |||
| controllers = [] | |||
| for disk_spec in self.params.get('disk'): | |||
| if not disk_spec['controller_type'] or not disk_spec['controller_number'] or not disk_spec['unit_number']: | |||
There was a problem hiding this comment.
Could you please add an integration test for this change? REST LGTM
There was a problem hiding this comment.
@Akasurde I think there already exists a test case for controller_number / unit_number 0:
But I don't understand why this didn't fail in the CI :-/
There was a problem hiding this comment.
Oh. This test playbook is not in the vmware_guest_test_playbooks: https://github.com/ansible-collections/community.vmware/blob/f913056612c776b6527aa3c373fe7cb7358d2762/tests/integration/targets/vmware_guest/defaults/main.yml
| @@ -19,6 +19,7 @@ vmware_guest_test_playbooks: | |||
| - mac_address_d1_c1_f0.yml | |||
| - max_connections.yml | |||
| - mem_reservation.yml | |||
| - multiple_disk_controllers_d1_c1_f0.yml | |||
There was a problem hiding this comment.
+1, hopefully it won't blow things up.
There was a problem hiding this comment.
@goneri Unfortunately, it did blow things up. I'll try to find out why.
There was a problem hiding this comment.
@Akasurde @goneri I think this is yet another problem with the vCenter simulator. I have moved those tests into a when: vcsim is not defined block.
Btw: It looks like we don't test against a real vCenter in the CI pipeline anymore. Would it be possible to get this back? It's really unfortunate that there are so many integration tests that are skipped because we only have vcsim.
|
@Akasurde @goneri What do you think, should we merge this PR? According to @MalfuncEddie it works and fixes the bug. |
Akasurde
added
gate
and removed
needs_triage
|
@Akasurde @goneri Did something change in the CI? ansible-test-sanity-docker worked in ansible/check but failed in ansible/gate. |
SUMMARY
The module fails when
disk.controller_numberordisk.unit_numberare 0.Fixes #703
ISSUE TYPE
COMPONENT NAME
vmware_guest
ADDITIONAL INFORMATION
community.vmware/plugins/modules/vmware_guest.py
Line 2480 in f913056
When
disk.controller_numberordisk.unit_numberare 0, the module fails becausenot 0isTrue. 0 is a valid value, the module should only fail if these parameters are not defined at all.