disk.controller_number and disk.unit_number set to 0 results in validation error because 0 == false in v1.8

[MalfuncEddie]

SUMMARY

Since v1.8 My playbook stopped working with the error

disk.controller_type', 'disk.controller_number' and 'disk.unit_number' are mandatory parameters when configure multiple disk controllers and disks.

Checking my playbook it does have all the parameters

reverting to version 1.7 did fix the issue. I think this might be due to #640 but can"t pinpoint the issue

ISSUE TYPE

• Bug Report

COMPONENT NAME

community.vmware/plugins/modules/vmware_guest.py

ANSIBLE VERSION

ansible 2.10.3
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/var/lib/awx/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /data/awx/awx_venvs/vmware_community/lib64/python3.6/site-packages/ansible
  executable location = /data/awx/awx_venvs/vmware_community/bin/ansible
  python version = 3.6.8 (default, Apr 16 2020, 01:36:27) [GCC 8.3.1 20191121 (Red Hat 8.3.1-5)]

CONFIGURATION

empty

OS / ENVIRONMENT

STEPS TO REPRODUCE

EXPECTED RESULTS

- name: Alter VM template
  community.vmware.vmware_guest:
    validate_certs: False
    hostname: '{{ lookup("env", "VMWARE_HOST") }}'
    username: '{{ lookup("env", "VMWARE_USER") }}'
    password: '{{ lookup("env", "VMWARE_PASSWORD") }}'
    host: "{{ set_esxi_hostname | default(omit) }}"
    cluster: "{{ set_cluster | default(omit) }}"
    datacenter: "{{ datacenter }}"
    folder: "{{ folder }}"
    name: "{{ vmname }}"
    customization:
      existing_vm: True
      hostname: "{{ vm_hostname | default(omit)}}"
    disk:
    - size_gb: "{{ disk_size }}"
      type: "{{ disktype |lower }}"
      controller_type : 'paravirtual'
      datastore: "{{ datastore_recommended }}"
      controller_number: 0
      unit_number: 0
    hardware:
      hotadd_memory: True
      memory_mb: "{{ vm_memory  }}"
      num_cpus: "{{ cpu  }}"
      boot_firmware: "{{ boot_firmware  }}"
      scsi: "{{ scsi }}"
    networks:
    - name: "{{ port_grp }}"
      device_type: "vmxnet3"
      start_connected: True
      type: "{{ net_type }}"
      ip: "{{ server_ip }}"
      netmask: "{{ netmask }}"
      gateway: "{{ gateway }}"
      domain: "{{ searchdomain }}"
      dns_servers:
        - "{{ dns1 }}"
        - "{{ dns2 }}"
    state: present

output (some info censored)

"msg": "'disk.controller_type', 'disk.controller_number' and 'disk.unit_number' are mandatory parameters when configure multiple disk controllers and disks.",
    "invocation": {
        "module_args": {
            "validate_certs": false,
            "hostname": "censored",
            "username": "censored",
            "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "cluster": "censored",
            "datacenter": "censored",
            "folder": "vm",
            "name": "censored",
            "customization": {
                "existing_vm": true,
                "autologon": null,
                "autologoncount": null,
                "dns_servers": null,
                "dns_suffix": null,
                "domain": null,
                "domainadmin": null,
                "domainadminpassword": null,
                "fullname": null,
                "hostname": null,
                "hwclockUTC": null,
                "joindomain": null,
                "joinworkgroup": null,
                "orgname": null,
                "password": null,
                "productid": null,
                "runonce": null,
                "timezone": null
            },
            "disk": [
                {
                    "size_gb": 45,
                    "type": "eagerzeroedthick",
                    "controller_type": "paravirtual",
                    "datastore": "censored",
                    "controller_number": 0,
                    "unit_number": 0,
                    "autoselect_datastore": null,
                    "disk_mode": null,
                    "filename": null,
                    "size": null,
                    "size_kb": null,
                    "size_mb": null,
                    "size_tb": null
                }
            ],
            "hardware": {
                "hotadd_memory": true,
                "memory_mb": 8096,
                "num_cpus": 2,
                "boot_firmware": "efi",
                "scsi": "paravirtual",
                "cpu_limit": null,
                "cpu_reservation": null,
                "hotadd_cpu": null,
                "hotremove_cpu": null,
                "max_connections": null,
                "mem_limit": null,
                "mem_reservation": null,
                "memory_reservation_lock": null,
                "nested_virt": null,
                "num_cpu_cores_per_socket": null,
                "version": null,
                "virt_based_security": null
            },
            "networks": [
                {
                    "name": "censored",
                    "device_type": "vmxnet3",
                    "start_connected": true,
                    "type": "static",
                    "ip": "censored",
                    "netmask": "censored",
                    "gateway": "censored",
                    "domain": "censored",
                    "dns_servers": [
                        "censored",
                        "censored"
                    ]
                }
            ],
            "state": "present",
            "port": 443,
            "is_template": false,
            "customvalues": [],
            "advanced_settings": [],
            "name_match": "first",
            "use_instance_uuid": false,
            "cdrom": [],
            "force": false,
            "wait_for_ip_address": false,
            "wait_for_ip_address_timeout": 300,
            "state_change_timeout": 0,
            "linked_clone": false,
            "wait_for_customization": false,
            "wait_for_customization_timeout": 3600,
            "vapp_properties": [],
            "delete_from_inventory": false,
            "proxy_host": null,
            "proxy_port": null,
            "template": null,
            "annotation": null,
            "uuid": null,
            "guest_id": null,
            "esxi_hostname": null,
            "snapshot_src": null,
            "resource_pool": null,
            "customization_spec": null,
            "datastore": null,
            "convert": null
        }
    },
    "_ansible_no_log": false,
    "changed": false

ACTUAL RESULTS

[ansibullbot]

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

Files identified in the description:

• [plugins/modules/vmware_guest.py](https://github.com/['ansible-collections/amazon.aws', 'ansible-collections/community.aws', 'ansible-collections/community.vmware']/blob/main/plugins/modules/vmware_guest.py)

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @Akasurde @Tomorrow9 @goneri @lparkes @nerzhul @pdellaert @pgbidkar @warthog9
click here for bot help

[MalfuncEddie]

Hi

community.vmware/plugins/modules/vmware_guest.py

Line 2480 in f913056

if not disk_spec['controller_type'] or not disk_spec['controller_number'] or not disk_spec['unit_number']:

should be changed to

 if not disk_spec['controller_type'] or (not disk_spec['controller_number'] and disk_spec['controller_number'] != 0) or (not disk_spec['unit_number'] and disk_spec['controller_number'] != 0):
            

Because it errors if the number is 0

[mariolenz]

@MalfuncEddie You're right, the problem is that not 0 is True. So I think the best way is to fail if 'disk.controller_type', 'disk.controller_number' or 'disk.unit_number' is None.

Can you please have a look at PR #705? I hope it will fix this.

[MalfuncEddie]

@mariolenz #705 looks good to me,
Just tested it and no issue. Tnx for the great work