vmware_guest: Define sub-options of disk in argument_spec

[mariolenz]

SUMMARY

As a follow-up to #595 I'd also like to define the inner structure of disk in argument_spec.

ISSUE TYPE

• Docs Pull Request

COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

I think that a correct argument_spec helps us a lot. For example, we don't have to check manually for a valid controller_type if we define choices=['buslogic', 'lsilogic', 'paravirtual', 'lsilogicsas', 'sata', 'nvme'].

[ansibullbot]

cc @Akasurde @Tomorrow9 @goneri @lparkes @nerzhul @pdellaert @pgbidkar @warthog9
click here for bot help

[mariolenz]

recheck

[mariolenz]

For the record: Last CI run failed to clone https://github.com/vmware/vsphere-automation-sdk-python.git

[mariolenz]

recheck

Unknown error while connecting to vCenter or ESXi API at esxi1.test:443 : [Errno 110] Connection timed out

[mariolenz]

recheck

[Akasurde]

recheck

[mariolenz]

recheck

[mariolenz]

recheck

[mariolenz]

This doesn't look to have anything to do with my changes, it looks like a CI problem:

ERROR: Could not build wheels for cryptography which use PEP 517 and cannot be installed directly

[Akasurde]

@mariolenz I think ansible/ansible#73525 will solve the CI related issue.

[mariolenz]

recheck

[MalfuncEddie]

Hi @mariolenz

could you please alter the line

community.vmware/plugins/modules/vmware_guest.py

Line 2480 in f913056

if not disk_spec['controller_type'] or not disk_spec['controller_number'] or not disk_spec['unit_number']:

to

if not disk_spec['controller_type'] or (not disk_spec['controller_number'] and disk_spec['controller_number'] != 0) or (not disk_spec['unit_number'] and disk_spec['controller_number'] != 0):

to solve #703