Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-1] Use vendored version of distutils.version #274

Merged

Conversation

Andersson007
Copy link
Collaborator

SUMMARY

Backport of #269

…ollections#267)

* Prepare for distutils.version being removed in Python 3.12

* Update plugins/module_utils/version.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit d9e12b8)
* Use vendored version of distutils.version

* Correct fragment

* Update plugins/module_utils/version.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 9c575b4)
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #274 (51423c5) into stable-1 (ace830e) will decrease coverage by 1.99%.
The diff coverage is 46.21%.

Impacted file tree graph

@@             Coverage Diff              @@
##           stable-1     #274      +/-   ##
============================================
- Coverage     77.15%   75.15%   -2.00%     
============================================
  Files            20       22       +2     
  Lines          1786     1900     +114     
  Branches        437      466      +29     
============================================
+ Hits           1378     1428      +50     
- Misses          265      323      +58     
- Partials        143      149       +6     
Impacted Files Coverage Δ
plugins/module_utils/_version.py 41.81% <41.81%> (ø)
...odule_utils/implementations/mariadb/replication.py 100.00% <100.00%> (ø)
...ugins/module_utils/implementations/mariadb/user.py 77.77% <100.00%> (ø)
.../module_utils/implementations/mysql/replication.py 100.00% <100.00%> (ø)
plugins/module_utils/implementations/mysql/user.py 100.00% <100.00%> (ø)
plugins/module_utils/version.py 100.00% <100.00%> (ø)
plugins/modules/mysql_replication.py 66.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace830e...51423c5. Read the comment docs.

@Andersson007 Andersson007 merged commit 9386045 into ansible-collections:stable-1 Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant