Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use vendored version of distutils.version #269

Merged
merged 3 commits into from
Jan 7, 2022

Conversation

Andersson007
Copy link
Collaborator

SUMMARY

#267

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #269 (5f93ff9) into main (d9e12b8) will decrease coverage by 1.76%.
The diff coverage is 42.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   78.86%   77.10%   -1.77%     
==========================================
  Files          26       27       +1     
  Lines        2139     2241     +102     
  Branches      495      524      +29     
==========================================
+ Hits         1687     1728      +41     
- Misses        297      352      +55     
- Partials      155      161       +6     
Impacted Files Coverage Δ
plugins/module_utils/_version.py 41.81% <41.81%> (ø)
plugins/module_utils/version.py 100.00% <100.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9e12b8...5f93ff9. Read the comment docs.

@Andersson007
Copy link
Collaborator Author

the CI failings are unrelated

@Andersson007 Andersson007 merged commit 9c575b4 into ansible-collections:main Jan 7, 2022
@Andersson007
Copy link
Collaborator Author

@felixfontein thanks for the solution and reviewing!

Andersson007 added a commit to Andersson007/community.mysql that referenced this pull request Jan 17, 2022
* Use vendored version of distutils.version

* Correct fragment

* Update plugins/module_utils/version.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 9c575b4)
Andersson007 added a commit to Andersson007/community.mysql that referenced this pull request Jan 17, 2022
* Use vendored version of distutils.version

* Correct fragment

* Update plugins/module_utils/version.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 9c575b4)
Andersson007 added a commit to Andersson007/community.mysql that referenced this pull request Jan 17, 2022
* Use vendored version of distutils.version

* Correct fragment

* Update plugins/module_utils/version.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 9c575b4)
Andersson007 added a commit that referenced this pull request Jan 18, 2022
* Prepare for distutils.version being removed in Python 3.12 (#267)

* Prepare for distutils.version being removed in Python 3.12

* Update plugins/module_utils/version.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit d9e12b8)

* Use vendored version of distutils.version (#269)

* Use vendored version of distutils.version

* Correct fragment

* Update plugins/module_utils/version.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 9c575b4)
Andersson007 added a commit that referenced this pull request Jan 18, 2022
* Prepare for distutils.version being removed in Python 3.12 (#267)

* Prepare for distutils.version being removed in Python 3.12

* Update plugins/module_utils/version.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit d9e12b8)

* Use vendored version of distutils.version (#269)

* Use vendored version of distutils.version

* Correct fragment

* Update plugins/module_utils/version.py

Co-authored-by: Felix Fontein <[email protected]>

Co-authored-by: Felix Fontein <[email protected]>
(cherry picked from commit 9c575b4)

* Add ignore-2.13.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants