Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vault_write fix ability to use data and write_ttl keys #404

Merged

Conversation

briantist
Copy link
Collaborator

SUMMARY

Fixes #389

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vault_write

@briantist briantist added the bug Something isn't working label Oct 15, 2023
@briantist briantist self-assigned this Oct 15, 2023
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85ead94) 98.86% compared to head (8e87152) 98.87%.

❗ Current head 8e87152 differs from pull request most recent head a6214ce. Consider uploading reports for the commit a6214ce to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
+ Coverage   98.86%   98.87%   +0.01%     
==========================================
  Files          82       82              
  Lines        4235     4282      +47     
  Branches      461      466       +5     
==========================================
+ Hits         4187     4234      +47     
  Misses         39       39              
  Partials        9        9              
Flag Coverage Δ
env_docker-default 98.87% <100.00%> (+0.01%) ⬆️
integration 81.05% <62.50%> (-0.26%) ⬇️
sanity 39.25% <25.00%> (-0.25%) ⬇️
target_auth_approle 89.47% <ø> (ø)
target_auth_aws_iam 50.00% <ø> (?)
target_auth_cert 86.36% <ø> (?)
target_auth_ldap 89.47% <ø> (ø)
target_auth_none 100.00% <ø> (?)
target_auth_userpass 85.71% <ø> (?)
target_connection_options 74.76% <ø> (?)
target_controller 84.08% <100.00%> (+0.14%) ⬆️
target_filter_vault_login_token 77.77% <ø> (?)
target_import 39.25% <25.00%> (-0.25%) ⬇️
target_lookup_hashi_vault 81.33% <ø> (ø)
target_lookup_vault_ansible_settings 56.07% <ø> (?)
target_lookup_vault_kv1_get 91.30% <ø> (ø)
target_lookup_vault_kv2_get 91.11% <ø> (ø)
target_lookup_vault_login 88.57% <ø> (ø)
target_lookup_vault_token_create 79.24% <ø> (ø)
target_lookup_vault_write 57.02% <62.50%> (-0.13%) ⬇️
target_module_utils 97.48% <ø> (ø)
target_module_vault_kv1_get 87.50% <ø> (ø)
target_module_vault_kv2_delete 56.93% <ø> (ø)
target_module_vault_kv2_get 87.23% <ø> (ø)
target_module_vault_kv2_write 57.32% <ø> (?)
target_module_vault_list 85.71% <ø> (ø)
target_module_vault_login 83.72% <ø> (?)
target_module_vault_pki_generate_certificate 78.72% <ø> (?)
target_module_vault_token_create 91.66% <ø> (ø)
target_module_vault_write 56.11% <62.50%> (-0.14%) ⬇️
target_modules 82.35% <100.00%> (+0.25%) ⬆️
units 95.60% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plugins/lookup/vault_write.py 100.00% <100.00%> (ø)
plugins/modules/vault_write.py 100.00% <100.00%> (ø)
tests/unit/plugins/lookup/test_vault_write.py 100.00% <100.00%> (ø)
tests/unit/plugins/modules/test_vault_write.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 5, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://ansible-collections.github.io/community.hashi_vault/branch/main

@briantist briantist modified the milestones: v5.1.0, v5.0.1 Nov 5, 2023
@briantist briantist marked this pull request as ready for review November 5, 2023 14:58
@briantist
Copy link
Collaborator Author

@M0NsTeRRR

@briantist briantist merged commit 97fde6a into ansible-collections:main Nov 5, 2023
37 checks passed
@briantist briantist deleted the vault_write/key-support branch November 5, 2023 15:28
@M0NsTeRRR
Copy link

Thanks you @briantist didnt had time to look into in thanks for your works 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't set keyword path in data
2 participants