Can't set keyword path in data

[M0NsTeRRR]

SUMMARY

We can't set path key in data, for example to configure ACME path in PKI plugin.
The issue is in hvac library see hvac/hvac#133
I've opened this issue to track it and add a fix when hvac will fix the issue

ISSUE TYPE

• Bug Report

COMPONENT NAME

ANSIBLE VERSION

2.15.0

COLLECTION VERSION

5.0.0

STEPS TO REPRODUCE

---
- name: Create vault secret
  community.hashi_vault.vault_write:
    url: https://127.0.0.1:8200
    token: token
    path: pki/config/cluster
    data:
      path: https://vault-active.vault.svc:8200/v1/pki

EXPECTED RESULTS

Update path value of pki/config/cluster

ACTUAL RESULTS

hvac.v1.Client.write() got multiple values for keyword argument 'path'

[M0NsTeRRR]

@briantist replying to your message here.

We can base the new code on :

• hvac.__version__ if supported
  or
• python 3.8 <

import pkg_resources
pkg_resources.get_distribution('hvac').version

python 3.8 >=

from importlib.metadata import version
version('hvac')

[briantist]

I think I prefer to use the method we use in other areas of the code where we try to use the desired method, and then fall back, so it'd be something like:

try:
    client.write_data(...)
except (NotImplementedError, AttributeError):
    self.warn("blah blah")
    client.write(...)

See for example:

• https://github.com/ansible-collections/community.hashi_vault/blob/main/plugins/module_utils/_auth_method_approle.py#L32-38
• https://github.com/ansible-collections/community.hashi_vault/blob/main/plugins/module_utils/_auth_method_token.py#L96-L100

In this case it'll be slightly different because the write method is not really deprecated, so I'm not sure if we'll actually warn or not, and if we do, I'm not yet sure what it will say.

It's also a different situation because eventually, the code will change back to preferring write (since that's our endgame ultimately), but the code doesn't need to account for that yet.

---

Since our CI can't currently use multiple hvac versions easily, we test this condition with unit tests instead, see for example:

• https://github.com/ansible-collections/community.hashi_vault/blob/main/tests/unit/plugins/module_utils/authentication/test_auth_token.py#L173-L182

[M0NsTeRRR]

Maybe something like this is better, I think we don't need to warn people that don't use 'path' or 'wrap_ttl' ?

try:
    client.write_data(data)
except (NotImplementedError, AttributeError):
    if "path" in data or "wrap_ttl" in data:
        raise_from(
            AnsibleError("To support 'path' and 'wrap_ttl' key in 'data' parameter you must have hvac >= 1.2"),
            HashiVaultValueError
        )
    else:
        client.write(data)

[briantist]

That seems reasonable, yeah!

[briantist]

Fix released!

• https://github.com/ansible-collections/community.hashi_vault/releases/tag/5.0.1
• https://galaxy.ansible.com/ui/repo/published/community/hashi_vault/?version=5.0.1