Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9255/9452a2c8 backport][stable-10] homebrew: fix incorrect handling of aliases #9289

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Dec 20, 2024

This is a backport of PR #9255 as merged into main (9452a2c).

SUMMARY

Fixes #9240

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

homebrew

ADDITIONAL INFORMATION

* Add failing test (See commit description)

Second assert returns this:

changed: [localhost] => changed=true
  changed_pkgs:
  - sqlite3
  msg: 'Changed: 1, Unchanged: 1'
  unchanged_pkgs:
  - sqlite

* Extract proper package_name from brew info using alisases

* Add changelog fragment

* Fix pep8

* Make sure sqlite is uninstalled beforehand

* Use `package_result is (not) changed` syntax in assertions

* Register more explicit names

* Fix handling of casks

(cherry picked from commit 9452a2c)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Dec 20, 2024
@felixfontein felixfontein merged commit df58182 into stable-10 Dec 20, 2024
129 checks passed
@felixfontein felixfontein deleted the patchback/backports/stable-10/9452a2c8ac06cd12446d5fe500d6c24506f62075/pr-9255 branch December 20, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug This issue/PR relates to a bug integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants