homebrew: fix incorrect handling of aliases #9255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Second assert returns this: changed: [localhost] => changed=true changed_pkgs: - sqlite3 msg: 'Changed: 1, Unchanged: 1' unchanged_pkgs: - sqlite
1 task
ansibullbot
added
bug
russoz
reviewed
Dec 16, 2024
|
@russoz Thanks for the review, I've also made a little change to handle casks correctly, the issue was flagged by the previous test run |
ansibullbot
removed
the
needs_revision
felixfontein
added
check-before-release
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #9289 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
* Add failing test (See commit description) Second assert returns this: changed: [localhost] => changed=true changed_pkgs: - sqlite3 msg: 'Changed: 1, Unchanged: 1' unchanged_pkgs: - sqlite * Extract proper package_name from brew info using alisases * Add changelog fragment * Fix pep8 * Make sure sqlite is uninstalled beforehand * Use `package_result is (not) changed` syntax in assertions * Register more explicit names * Fix handling of casks (cherry picked from commit 9452a2c)
|
@UnknownPlatypus thanks for fixing this! |
felixfontein
pushed a commit
that referenced
this pull request
Dec 20, 2024
…ing of aliases (#9289) homebrew: fix incorrect handling of aliases (#9255) * Add failing test (See commit description) Second assert returns this: changed: [localhost] => changed=true changed_pkgs: - sqlite3 msg: 'Changed: 1, Unchanged: 1' unchanged_pkgs: - sqlite * Extract proper package_name from brew info using alisases * Add changelog fragment * Fix pep8 * Make sure sqlite is uninstalled beforehand * Use `package_result is (not) changed` syntax in assertions * Register more explicit names * Fix handling of casks (cherry picked from commit 9452a2c) Co-authored-by: Thibaut Decombe <[email protected]>
erichoog
pushed a commit
to erichoog/community.general
that referenced
this pull request
Dec 23, 2024
* Add failing test (See commit description) Second assert returns this: changed: [localhost] => changed=true changed_pkgs: - sqlite3 msg: 'Changed: 1, Unchanged: 1' unchanged_pkgs: - sqlite * Extract proper package_name from brew info using alisases * Add changelog fragment * Fix pep8 * Make sure sqlite is uninstalled beforehand * Use `package_result is (not) changed` syntax in assertions * Register more explicit names * Fix handling of casks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #9240
ISSUE TYPE
COMPONENT NAME
homebrew
ADDITIONAL INFORMATION