dnf_config_manager: fix parsing for non-english locales #9157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
russoz
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Hi @shamilovstas thanks for your contribution!
Couple of minor things to adjust, otherwise LGTM.
Co-authored-by: Alexei Znamensky <[email protected]>
felixfontein
added
check-before-release
Backport to stable-9: 💚 backport PR created✅ Backport PR branch: Backported as #9165 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
* dnf_config_manager: forces locale to 'C' when the module starts * adds changelog fragment * Apply suggestions from code review Co-authored-by: Alexei Znamensky <[email protected]> --------- Co-authored-by: Alexei Znamensky <[email protected]> (cherry picked from commit 4b0d5cb)
|
@shamilovstas thanks for fixing this! |
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #9166 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
* dnf_config_manager: forces locale to 'C' when the module starts * adds changelog fragment * Apply suggestions from code review Co-authored-by: Alexei Znamensky <[email protected]> --------- Co-authored-by: Alexei Znamensky <[email protected]> (cherry picked from commit 4b0d5cb)
felixfontein
pushed a commit
that referenced
this pull request
Nov 20, 2024
…g for non-english locales (#9165) dnf_config_manager: fix parsing for non-english locales (#9157) * dnf_config_manager: forces locale to 'C' when the module starts * adds changelog fragment * Apply suggestions from code review Co-authored-by: Alexei Znamensky <[email protected]> --------- Co-authored-by: Alexei Znamensky <[email protected]> (cherry picked from commit 4b0d5cb) Co-authored-by: Stanislav Shamilov <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
Nov 20, 2024
…ng for non-english locales (#9166) dnf_config_manager: fix parsing for non-english locales (#9157) * dnf_config_manager: forces locale to 'C' when the module starts * adds changelog fragment * Apply suggestions from code review Co-authored-by: Alexei Znamensky <[email protected]> --------- Co-authored-by: Alexei Znamensky <[email protected]> (cherry picked from commit 4b0d5cb) Co-authored-by: Stanislav Shamilov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #9046
ISSUE TYPE
COMPONENT NAME
dnf_config_manager
ADDITIONAL INFORMATION