dnf_config_manager: fix parsing for non-english locales (#9157)

shamilovstas · russoz · web-flow · commit 4b0d5cb8cfc9 · 2024-11-20T19:08:34.000+01:00
* dnf_config_manager: forces locale to 'C' when the module starts

* adds changelog fragment

* Apply suggestions from code review

Co-authored-by: Alexei Znamensky &lt;103110+russoz@users.noreply.github.com&gt;

---------

Co-authored-by: Alexei Znamensky &lt;103110+russoz@users.noreply.github.com&gt;
diff --git a/changelogs/fragments/9157-fix-dnf_config_manager-locale.yml b/changelogs/fragments/9157-fix-dnf_config_manager-locale.yml
@@ -0,0 +1,2 @@
+bugfixes:
+  - dnf_config_manager - forces locale to ``C`` before module starts. If the locale was set to non-English, the output of the ``dnf config-manager`` could not be parsed (https://github.com/ansible-collections/community.general/pull/9157, https://github.com/ansible-collections/community.general/issues/9046).
diff --git a/plugins/modules/dnf_config_manager.py b/plugins/modules/dnf_config_manager.py
@@ -186,6 +186,7 @@ def main():
         argument_spec=module_args,
         supports_check_mode=True
     )
+    module.run_command_environ_update = dict(LANGUAGE='C', LC_ALL='C')
 
     if not os.path.exists(DNF_BIN):
         module.fail_json(msg="%s was not found" % DNF_BIN)

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+bugfixes:`
	`2`	+ - dnf_config_manager - forces locale to ``C`` before module starts. If the locale was set to non-English, the output of the ``dnf config-manager`` could not be parsed (https://github.com/ansible-collections/community.general/pull/9157, https://github.com/ansible-collections/community.general/issues/9046).
Original file line number	Diff line number	Diff line change
`@@ -186,6 +186,7 @@ def main():`
`186`	`186`	`argument_spec=module_args,`
`187`	`187`	`supports_check_mode=True`
`188`	`188`	`)`
	`189`	`+ module.run_command_environ_update = dict(LANGUAGE='C', LC_ALL='C')`
`189`	`190`
`190`	`191`	`if not os.path.exists(DNF_BIN):`
`191`	`192`	`module.fail_json(msg="%s was not found" % DNF_BIN)`