Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elb_target_group make health_check_protocol required if health_check_path or successful_response_codes is set #1354

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jul 14, 2022

fixes: #29

SUMMARY

health_check_path and successful_response_codes were previously silently dropped on the floor if health_check_protocol wasn't set.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

elb_target_group

ADDITIONAL INFORMATION

@ansibullbot
Copy link

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review module module needs_triage plugins plugin (any type) labels Jul 14, 2022
@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 3m 59s
✔️ build-ansible-collection SUCCESS in 5m 08s
✔️ ansible-test-sanity-docker-devel SUCCESS in 11m 51s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 37s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 38s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 26s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 28s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 04s
✔️ ansible-test-splitter SUCCESS in 2m 29s
✔️ integration-community.aws-1 SUCCESS in 20m 20s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jul 15, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 04s
✔️ build-ansible-collection SUCCESS in 4m 50s
✔️ ansible-test-sanity-docker-devel SUCCESS in 12m 44s (non-voting)
✔️ ansible-test-sanity-docker-milestone SUCCESS in 10m 26s
✔️ ansible-test-sanity-docker-stable-2.12 SUCCESS in 10m 34s
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 9m 24s
✔️ ansible-test-units-community-aws-python38 SUCCESS in 6m 07s
✔️ ansible-test-units-community-aws-python39 SUCCESS in 6m 59s
✔️ ansible-test-splitter SUCCESS in 2m 34s
✔️ integration-community.aws-1 SUCCESS in 22m 06s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d23b02b into ansible-collections:main Jul 15, 2022
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@tremble tremble deleted the issues/29 branch September 9, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review mergeit Merge the PR (SoftwareFactory) module module needs_triage plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

elb_target_group doesn't change health_check_path on existing target group
3 participants