-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elb_target_group doesn't change health_check_path on existing target group #29
Labels
affects_2.10
bug
This issue/PR relates to a bug
module
module
needs_verified
plugins
plugin (any type)
Comments
Files identified in the description: If these files are inaccurate, please update the |
ansibullbot
added
affects_2.10
bug
This issue/PR relates to a bug
module
module
needs_triage
labels
Aug 19, 2020
tremble
added a commit
to tremble/community.aws
that referenced
this issue
Jul 14, 2022
…l_response_codes is set fixes: ansible-collections#29
tremble
added a commit
to tremble/community.aws
that referenced
this issue
Jul 14, 2022
…l_response_codes is set fixes: ansible-collections#29
softwarefactory-project-zuul bot
pushed a commit
that referenced
this issue
Jul 15, 2022
…l_response_codes is set (#1354) elb_target_group make health_check_protocol required if health_check_path or successful_response_codes is set fixes: #29 SUMMARY health_check_path and successful_response_codes were previously silently dropped on the floor if health_check_protocol wasn't set. ISSUE TYPE Bugfix Pull Request COMPONENT NAME elb_target_group ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects_2.10
bug
This issue/PR relates to a bug
module
module
needs_verified
plugins
plugin (any type)
Resubmitted from ansible-collections/amazon.aws#15
SUMMARY
Thehealth_check_path
option is ignored on an existing target group. Changing it gives a status ofok
and the setting is not changed.I suspect this affects more health check options but haven't tried them.
Turns out this is a duplicate of ansible/ansible#50024
You have to supply
health_check_protocol
in order forhealth_check_path
to be considered.But the documentation still doesn't reflect that.
And really, the purpose of the check for the protocol is to ignore other params that only apply to
http
andhttps
protocols. The check should:health_check_protocol
is the same asprotocol
if the former is not supplied, since that's what happens in realitySo I think this should remain open.
ISSUE TYPE
COMPONENT NAME
elb_target_group
ANSIBLE VERSION
2.9
CONFIGURATION
OS / ENVIRONMENT
STEPS TO REPRODUCE
health_check_path
option to something elseEXPECTED RESULTS
changed
status with updated valueACTUAL RESULTS
ok
status with no changeThe text was updated successfully, but these errors were encountered: