[PR #1054/ce418676 backport][stable-3] iam_role - delete inline policies, stabilize for migration to amazon.aws #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…aws (#1054) iam_role - delete inline policies, stabilize for migration to amazon.aws SUMMARY Stabilize for migration to amazon.aws delete inline policies before deleting the role removed global vars and refactored function definitions added some extra integration tests for check mode ISSUE TYPE Feature Pull Request COMPONENT NAME iam_role Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> (cherry picked from commit ce41867)
ansibullbot
added
community_review
feature
|
is this considered a breaking change? |
imo it's more like a bugfix? When it is a breaking change, the changelog fragment is wrong. |
tremble
approved these changes
Apr 14, 2022
I don't see anything I would consider 'breaking'. I would call this a bugfix rather than breaking change. The need to delete inline policies first was never documented, and what we do document is that |
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/ce4186763f5fecf45642bf956588afb659640e05/pr-1054
branch
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…#1063) Add route53 sanity ignore entry for 2.15 (devel) Depends-On: ansible-collections#1066 SUMMARY SSIA ISSUE TYPE Feature Pull Request COMPONENT NAME tests/sanity ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1054 as merged into main (ce41867).
SUMMARY
Stabilize for migration to amazon.aws
ISSUE TYPE
COMPONENT NAME
iam_role