-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iam_role - delete inline policies, stabilize for migration to amazon.aws #1054
iam_role - delete inline policies, stabilize for migration to amazon.aws #1054
Conversation
d11b6a5
to
57c58f2
Compare
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #1062 🤖 @patchback |
…aws (#1054) iam_role - delete inline policies, stabilize for migration to amazon.aws SUMMARY Stabilize for migration to amazon.aws delete inline policies before deleting the role removed global vars and refactored function definitions added some extra integration tests for check mode ISSUE TYPE Feature Pull Request COMPONENT NAME iam_role Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> (cherry picked from commit ce41867)
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #1063 🤖 @patchback |
…aws (#1054) iam_role - delete inline policies, stabilize for migration to amazon.aws SUMMARY Stabilize for migration to amazon.aws delete inline policies before deleting the role removed global vars and refactored function definitions added some extra integration tests for check mode ISSUE TYPE Feature Pull Request COMPONENT NAME iam_role Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> (cherry picked from commit ce41867)
…aws (#1054) (#1063) [PR #1054/ce418676 backport][stable-3] iam_role - delete inline policies, stabilize for migration to amazon.aws This is a backport of PR #1054 as merged into main (ce41867). SUMMARY Stabilize for migration to amazon.aws delete inline policies before deleting the role removed global vars and refactored function definitions added some extra integration tests for check mode ISSUE TYPE Feature Pull Request COMPONENT NAME iam_role Reviewed-by: Mark Chappell <None>
…aws (#1054) (#1062) [PR #1054/ce418676 backport][stable-2] iam_role - delete inline policies, stabilize for migration to amazon.aws This is a backport of PR #1054 as merged into main (ce41867). SUMMARY Stabilize for migration to amazon.aws delete inline policies before deleting the role removed global vars and refactored function definitions added some extra integration tests for check mode ISSUE TYPE Feature Pull Request COMPONENT NAME iam_role Reviewed-by: Mark Chappell <None>
Revert breaking change - iam_role return values SUMMARY This hasn't been release yet, so a changelog isn't needed. While I'm generally good with cleaning up the output values here, this needs to be done as a separate breaking change, and must not be backported to stable-3. ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role ADDITIONAL INFORMATION Breaking change silently introduced by #1054 Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None>
Revert breaking change - iam_role return values SUMMARY This hasn't been release yet, so a changelog isn't needed. While I'm generally good with cleaning up the output values here, this needs to be done as a separate breaking change, and must not be backported to stable-3. ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role ADDITIONAL INFORMATION Breaking change silently introduced by #1054 Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 8d80e9a)
Revert breaking change - iam_role return values SUMMARY This hasn't been release yet, so a changelog isn't needed. While I'm generally good with cleaning up the output values here, this needs to be done as a separate breaking change, and must not be backported to stable-3. ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role ADDITIONAL INFORMATION Breaking change silently introduced by #1054 Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 8d80e9a)
[PR #1068/8d80e9a0 backport][stable-2] Revert breaking change - iam_role return values This is a backport of PR #1068 as merged into main (8d80e9a). SUMMARY This hasn't been release yet, so a changelog isn't needed. While I'm generally good with cleaning up the output values here, this needs to be done as a separate breaking change, and must not be backported to stable-3. ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role ADDITIONAL INFORMATION Breaking change silently introduced by #1054 Reviewed-by: Mark Chappell <None>
[PR #1068/8d80e9a0 backport][stable-3] Revert breaking change - iam_role return values This is a backport of PR #1068 as merged into main (8d80e9a). SUMMARY This hasn't been release yet, so a changelog isn't needed. While I'm generally good with cleaning up the output values here, this needs to be done as a separate breaking change, and must not be backported to stable-3. ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role ADDITIONAL INFORMATION Breaking change silently introduced by #1054 Reviewed-by: Mark Chappell <None>
iam_role - add assume_role_policy_document_raw SUMMARY fixes: #551 assume_role_policy_document is an IAM policy document, and as such we shouldn't be modifying it. Running camel / snake conversion against the document breaks it. Adds assume_role_policy_document_raw and deprecates the current snake_case behaviour. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_role iam_role_info ADDITIONAL INFORMATION Follows up on #1054 / #1068 Reviewed-by: Alina Buzachis <None>
iam_role - add assume_role_policy_document_raw SUMMARY fixes: #551 assume_role_policy_document is an IAM policy document, and as such we shouldn't be modifying it. Running camel / snake conversion against the document breaks it. Adds assume_role_policy_document_raw and deprecates the current snake_case behaviour. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_role iam_role_info ADDITIONAL INFORMATION Follows up on #1054 / #1068 Reviewed-by: Alina Buzachis <None> (cherry picked from commit 5bf51c0)
[PR #1692/5bf51c0d backport][stable-5] iam_role - add assume_role_policy_document_raw This is a backport of PR #1692 as merged into main (5bf51c0). SUMMARY fixes: #551 assume_role_policy_document is an IAM policy document, and as such we shouldn't be modifying it. Running camel / snake conversion against the document breaks it. Adds assume_role_policy_document_raw and deprecates the current snake_case behaviour. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_role iam_role_info ADDITIONAL INFORMATION Follows up on #1054 / #1068 Reviewed-by: Mark Chappell <None>
…e_kms_key Promote kms_key* modules and tests SUMMARY Depends-On: ansible/zuul-config#445 Migrate kms_key* module from community.aws ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
…aws (ansible-collections#1054) iam_role - delete inline policies, stabilize for migration to amazon.aws SUMMARY Stabilize for migration to amazon.aws delete inline policies before deleting the role removed global vars and refactored function definitions added some extra integration tests for check mode ISSUE TYPE Feature Pull Request COMPONENT NAME iam_role Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@ce41867
…1068) Revert breaking change - iam_role return values SUMMARY This hasn't been release yet, so a changelog isn't needed. While I'm generally good with cleaning up the output values here, this needs to be done as a separate breaking change, and must not be backported to stable-3. ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_role ADDITIONAL INFORMATION Breaking change silently introduced by ansible-collections#1054 Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@8d80e9a
) iam_role - add assume_role_policy_document_raw SUMMARY fixes: ansible-collections#551 assume_role_policy_document is an IAM policy document, and as such we shouldn't be modifying it. Running camel / snake conversion against the document breaks it. Adds assume_role_policy_document_raw and deprecates the current snake_case behaviour. ISSUE TYPE Feature Pull Request COMPONENT NAME iam_role iam_role_info ADDITIONAL INFORMATION Follows up on ansible-collections#1054 / ansible-collections#1068 Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@5bf51c0
SUMMARY
Stabilize for migration to amazon.aws
ISSUE TYPE
COMPONENT NAME
iam_role