Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys #858

Conversation

alinabuzachis
Copy link
Contributor

@alinabuzachis alinabuzachis commented Jun 2, 2022

SUMMARY

Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys

include_filters and exclude_filters have been added #328 and released with amazon.aws 1.5.0

use_contrib_script_compatible_ec2_tag_keys has been added #331 and released with amazon.aws 1.5.0

Let's update the aws_ec2 inventory plugin documentation with this information.

This should be a step towards closing this one #676 and #675

aws_ec2 documentation will be enriched with exhaustive examples in an upcoming PR.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

aws_ec2

ADDITIONAL INFORMATION

…_contrib_script_compatible_ec2_tag_keys

Signed-off-by: Alina Buzachis <[email protected]>
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 25s
✔️ build-ansible-collection SUCCESS in 8m 04s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 34s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 27m 01s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 9m 21s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 55s
✔️ ansible-test-splitter SUCCESS in 2m 47s
✔️ integration-amazon.aws-1 SUCCESS in 42m 32s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@tremble tremble added backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch mergeit Merge the PR (SoftwareFactory) labels Jun 7, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 22s
✔️ build-ansible-collection SUCCESS in 4m 46s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 09s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 11m 42s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 8m 40s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 43s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 42s
✔️ ansible-test-splitter SUCCESS in 2m 25s
✔️ integration-amazon.aws-1 SUCCESS in 34m 55s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 5f05853 into ansible-collections:main Jun 7, 2022
@patchback
Copy link

patchback bot commented Jun 7, 2022

Backport to stable-2: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 5f05853 on top of patchback/backports/stable-2/5f0585327cd9bd8165154526942df55ec76cccdc/pr-858

Backporting merged PR #858 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/amazon.aws.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-2/5f0585327cd9bd8165154526942df55ec76cccdc/pr-858 upstream/stable-2
  4. Now, cherry-pick PR Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys #858 contents into that branch:
    $ git cherry-pick -x 5f0585327cd9bd8165154526942df55ec76cccdc
    If it'll yell at you with something like fatal: Commit 5f0585327cd9bd8165154526942df55ec76cccdc is a merge but no -m option was given., add -m 1 as follows intead:
    $ git cherry-pick -m1 -x 5f0585327cd9bd8165154526942df55ec76cccdc
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys #858 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-2/5f0585327cd9bd8165154526942df55ec76cccdc/pr-858
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Jun 7, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/5f0585327cd9bd8165154526942df55ec76cccdc/pr-858

Backported as #868

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 7, 2022
…_contrib_script_compatible_ec2_tag_keys (#858)

Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys

SUMMARY

Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys
include_filters and exclude_filters have been added #328 and released with amazon.aws 1.5.0
use_contrib_script_compatible_ec2_tag_keys has been added #331 and released with  amazon.aws 1.5.0
Let's update the aws_ec2 inventory plugin documentation with this information.
This should be a step towards closing this one #676 and #675
aws_ec2 documentation will be enriched with exhaustive examples in an upcoming PR.

ISSUE TYPE

Docs Pull Request

COMPONENT NAME

aws_ec2
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
(cherry picked from commit 5f05853)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 7, 2022
…_contrib_script_compatible_ec2_tag_keys (#858) (#868)

[PR #858/5f058532 backport][stable-3] Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys

This is a backport of PR #858 as merged into main (5f05853).
SUMMARY

Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys
include_filters and exclude_filters have been added #328 and released with amazon.aws 1.5.0
use_contrib_script_compatible_ec2_tag_keys has been added #331 and released with  amazon.aws 1.5.0
Let's update the aws_ec2 inventory plugin documentation with this information.
This should be a step towards closing this one #676 and #675
aws_ec2 documentation will be enriched with exhaustive examples in an upcoming PR.

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

aws_ec2
ADDITIONAL INFORMATION
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 22, 2022
…_contrib_script_compatible_ec2_tag_keys (#884)

aws_ec2 add version_added: 1.5.0 (backport to stable-2)

SUMMARY

Manual backport of #858 to stable 2

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

aws_ec2

Reviewed-by: Mark Chappell <None>
jatorcasso pushed a commit to jatorcasso/amazon.aws that referenced this pull request Jun 27, 2022
…_contrib_script_compatible_ec2_tag_keys (ansible-collections#858)

Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys

SUMMARY

Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys
include_filters and exclude_filters have been added ansible-collections#328 and released with amazon.aws 1.5.0
use_contrib_script_compatible_ec2_tag_keys has been added ansible-collections#331 and released with  amazon.aws 1.5.0
Let's update the aws_ec2 inventory plugin documentation with this information.
This should be a step towards closing this one ansible-collections#676 and ansible-collections#675
aws_ec2 documentation will be enriched with exhaustive examples in an upcoming PR.

ISSUE TYPE


Docs Pull Request

COMPONENT NAME

aws_ec2
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Add 'opensearch' and 'opensearch_info' modules

SUMMARY


Add opensearch module to create/update AWS OpenSearch/Elasticsearch  domains.
Add opensearch_info module to query AWS OpenSearch/Elasticsearch domains.

Fixes ansible-collections#858
Requires mattclay/aws-terminator#187

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

Creates OpenSearch or ElasticSearch domain.
ADDITIONAL INFORMATION



The minimum version of botocore for these modules is 1.21.38.
The integration tests take more than 4 hours to execute. Tests time out in the CI. I was able to run the integration tests locally.

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Sebastien Rosset <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Add 'opensearch' and 'opensearch_info' modules

SUMMARY


Add opensearch module to create/update AWS OpenSearch/Elasticsearch  domains.
Add opensearch_info module to query AWS OpenSearch/Elasticsearch domains.

Fixes ansible-collections#858
Requires mattclay/aws-terminator#187

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

Creates OpenSearch or ElasticSearch domain.
ADDITIONAL INFORMATION



The minimum version of botocore for these modules is 1.21.38.
The integration tests take more than 4 hours to execute. Tests time out in the CI. I was able to run the integration tests locally.

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Sebastien Rosset <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Add 'opensearch' and 'opensearch_info' modules

SUMMARY


Add opensearch module to create/update AWS OpenSearch/Elasticsearch  domains.
Add opensearch_info module to query AWS OpenSearch/Elasticsearch domains.

Fixes ansible-collections#858
Requires mattclay/aws-terminator#187

ISSUE TYPE


New Module Pull Request

COMPONENT NAME

Creates OpenSearch or ElasticSearch domain.
ADDITIONAL INFORMATION



The minimum version of botocore for these modules is 1.21.38.
The integration tests take more than 4 hours to execute. Tests time out in the CI. I was able to run the integration tests locally.

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Sebastien Rosset <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Markus Bergholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch community_review docs inventory inventory plugin mergeit Merge the PR (SoftwareFactory) needs_triage plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants