-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use_contrib_script_compatible_ec2_tag_keys compatibility version #676
Labels
docs
inventory
inventory plugin
jira
needs_verified
Some one might want to take a look at this and reproduce it to confirm
plugins
plugin (any type)
Comments
Files identified in the description:
If these files are inaccurate, please update the |
ansibullbot
added
docs
inventory
inventory plugin
needs_triage
plugins
plugin (any type)
labels
Feb 15, 2022
alinabuzachis
added
needs_verified
Some one might want to take a look at this and reproduce it to confirm
jira
and removed
needs_triage
labels
Mar 1, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this issue
Jun 7, 2022
…_contrib_script_compatible_ec2_tag_keys (#858) Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys SUMMARY Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys include_filters and exclude_filters have been added #328 and released with amazon.aws 1.5.0 use_contrib_script_compatible_ec2_tag_keys has been added #331 and released with amazon.aws 1.5.0 Let's update the aws_ec2 inventory plugin documentation with this information. This should be a step towards closing this one #676 and #675 aws_ec2 documentation will be enriched with exhaustive examples in an upcoming PR. ISSUE TYPE Docs Pull Request COMPONENT NAME aws_ec2 ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
patchback bot
pushed a commit
that referenced
this issue
Jun 7, 2022
…_contrib_script_compatible_ec2_tag_keys (#858) Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys SUMMARY Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys include_filters and exclude_filters have been added #328 and released with amazon.aws 1.5.0 use_contrib_script_compatible_ec2_tag_keys has been added #331 and released with amazon.aws 1.5.0 Let's update the aws_ec2 inventory plugin documentation with this information. This should be a step towards closing this one #676 and #675 aws_ec2 documentation will be enriched with exhaustive examples in an upcoming PR. ISSUE TYPE Docs Pull Request COMPONENT NAME aws_ec2 ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None> (cherry picked from commit 5f05853)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this issue
Jun 7, 2022
…_contrib_script_compatible_ec2_tag_keys (#858) (#868) [PR #858/5f058532 backport][stable-3] Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys This is a backport of PR #858 as merged into main (5f05853). SUMMARY Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys include_filters and exclude_filters have been added #328 and released with amazon.aws 1.5.0 use_contrib_script_compatible_ec2_tag_keys has been added #331 and released with amazon.aws 1.5.0 Let's update the aws_ec2 inventory plugin documentation with this information. This should be a step towards closing this one #676 and #675 aws_ec2 documentation will be enriched with exhaustive examples in an upcoming PR. ISSUE TYPE Docs Pull Request COMPONENT NAME aws_ec2 ADDITIONAL INFORMATION
jatorcasso
pushed a commit
to jatorcasso/amazon.aws
that referenced
this issue
Jun 27, 2022
…_contrib_script_compatible_ec2_tag_keys (ansible-collections#858) Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys SUMMARY Add version_added: 1.5.0 for exclude_filters, include_filters and use_contrib_script_compatible_ec2_tag_keys include_filters and exclude_filters have been added ansible-collections#328 and released with amazon.aws 1.5.0 use_contrib_script_compatible_ec2_tag_keys has been added ansible-collections#331 and released with amazon.aws 1.5.0 Let's update the aws_ec2 inventory plugin documentation with this information. This should be a step towards closing this one ansible-collections#676 and ansible-collections#675 aws_ec2 documentation will be enriched with exhaustive examples in an upcoming PR. ISSUE TYPE Docs Pull Request COMPONENT NAME aws_ec2 ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
@danielmotaleite Has been addressed by #858 |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this issue
Oct 24, 2023
…_mode_2 Add supports_check_mode to cloudformation_exports_info cloudfront_info SUMMARY as _info modules they should run in check mode See also ansible-collections#659 (missed in my first pass) ISSUE TYPE Bugfix Pull Request COMPONENT NAME cloudformation_exports_info cloudfront_info ADDITIONAL INFORMATION https://dashboard.zuul.ansible.com/t/ansible/build/a5f8c6effd7745eca0b06a5a1bef7b08 ERROR: plugins/modules/cloudformation_exports_info.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.supports_check_mode: not a valid value for dictionary value @ data['supports_check_mode']. Got False ERROR: plugins/modules/cloudfront_info.py:0:0: invalid-ansiblemodule-schema: AnsibleModule.supports_check_mode: not a valid value for dictionary value @ data['supports_check_mode']. Got False Reviewed-by: Jill R <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
inventory
inventory plugin
jira
needs_verified
Some one might want to take a look at this and reproduce it to confirm
plugins
plugin (any type)
Summary
In https://docs.ansible.com/ansible/latest/collections/amazon/aws/aws_ec2_inventory.html#parameter-use_contrib_script_compatible_ec2_tag_keys
The use_contrib_script_compatible_ec2_tag_keys do not work in ansible 2.9, but the documentation fail to specify when it was introduced, so users are left to guess to what version they should upgrade.
Also, the option should point to #675 compatibility examples for older versions or simple workaround for just a few missing features
Issue Type
Documentation Report
Component Name
aws_ec2
Ansible Version
$ ansible --version
Collection Versions
No response
Configuration
No response
OS / Environment
No response
Additional Information
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: