Migrate ec2_vpc_endpoint* modules and tests #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alinabuzachis: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
integration
alinabuzachis
force-pushed
the
promote_ec2_vpc_endpoint
branch
4 times, most recently
from
a748800
to
5e9fd7d
Compare
ansibullbot
added
needs_rebase
alinabuzachis
force-pushed
the
promote_ec2_vpc_endpoint
branch
from
5e9fd7d
to
000c30e
Compare
ansibullbot
removed
needs_rebase
alinabuzachis
force-pushed
the
promote_ec2_vpc_endpoint
branch
3 times, most recently
from
ce7e5a2
to
27207f5
Compare
|
When this is merged please make sure to migrate the issues (there's a nice button for it) |
|
recheck |
alinabuzachis
force-pushed
the
promote_ec2_vpc_endpoint
branch
from
27207f5
to
eb445a6
Compare
ansibullbot
added
needs_rebase
* deprecate policy_file * ignore file * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@820e5cd
* Ensure ec2_vpc_endpoint returns True when deleting an Endpoint Return not changed when state=absent and endpoint has already been deleted * Add minimal endpoint tests This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@a89ec90
* More aliases cleanup * Mark ec2_classic_lb tests unstable * Add more comments about why tests aren't enabled This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cb55efa
* Added support for 'vpc_endpoint_type'. * Integration test for the 'vpc_endpoint_type' feature. * Added choices in documentation. * Added changelog. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4da568a
* Add no_log=False to mark some more false-positives of the no_log check. * More false-positives confirmed by tremble. This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@67b6d75
* New module - ec2_vpc_endpoint_service_info * Deprecate querying services through ec2_vpc_endpoint_info * Attempt to cope with some services which have who possible endpoints Co-authored-by: Jill R <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b48c1ee
* Stabilize and improve ec2_vpc_endpoint modules - Add tagging support - Make idempotent - Better exception handling - Better check_mode support - Use module_utils for common functions - Enable retries on common AWS failures * Make endpoint deletion idempotent in check_mode * Sanity fixes * Address review feedback This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@f1d338d
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@8acde77
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@a0d4d96
… 3.6/boto3 This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@c097c55
This collection has been operating on Zuul CI for some weeks now This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@4e0d83c
This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@6d420e5
alinabuzachis
force-pushed
the
promote_ec2_vpc_endpoint
branch
from
0a58ad5
to
a6d109d
Compare
ansible-zuul bot
added a commit
to ansible/project-config
that referenced
this pull request
Aug 26, 2021
…-strategy_26775 amazon.aws: temp turn on the merge strategy Disable the squash-merge merge strategy just the time we land ansible-collections/amazon.aws#435 ansible-collections/amazon.aws#410 Reviewed-by: None <None>
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
goneri
added a commit
to goneri/project-config
that referenced
this pull request
Aug 26, 2021
Depends-On: ansible-collections/amazon.aws#435 Depends-On: ansible-collections/amazon.aws#410 This reverts commit 7dd6b71 since we don't need it anymore.
ansible-zuul bot
added a commit
to ansible/project-config
that referenced
this pull request
Aug 27, 2021
…e-merge-strategy_24403 Revert "amazon.aws: temp turn on the merge strategy" Depends-On: ansible-collections/amazon.aws#435 Depends-On: ansible-collections/amazon.aws#410 This reverts commit 7dd6b71 since we don't need it anymore. Reviewed-by: None <None>
ansible-zuul bot
added a commit
to ansible-collections/community.aws
that referenced
this pull request
Aug 27, 2021
Migrate ec2_vpc_endpoint* modules and tests Depends-On: ansible-collections/amazon.aws#435 Remove ec2_vpc_endpoint* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate ec2_vpc_endpoint* modules and tests