Skip to content

Commit

Permalink
Yet more integration test aliases file cleanup (#431)
Browse files Browse the repository at this point in the history
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled
  • Loading branch information
tremble authored Feb 21, 2021
1 parent cd1430d commit cb55efa
Show file tree
Hide file tree
Showing 28 changed files with 71 additions and 29 deletions.
7 changes: 5 additions & 2 deletions tests/integration/targets/aws_acm/aliases
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# https://github.com/ansible/ansible/issues/67788
unstable

cloud/aws
aws_acm_info
shippable/aws/group2
unstable

aws_acm_info
2 changes: 1 addition & 1 deletion tests/integration/targets/aws_config/aliases
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# reason: missing-policy
# We don't have CI or 'unsupported' policy for AWS config
disabled
unsupported

cloud/aws
shippable/aws/group2
Expand Down
5 changes: 4 additions & 1 deletion tests/integration/targets/aws_eks_cluster/aliases
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# reason: unknown
# reason: missing-policy
# We don't have CI or 'unsupported' policy for AWS config
# reason: slow
# Starting up an EKS cluster is a slow process, tests can take 40 minutes
unsupported

cloud/aws
9 changes: 6 additions & 3 deletions tests/integration/targets/aws_kms/aliases
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
cloud/aws
aws_kms_info
shippable/aws/group2
# Various race conditions - likely needs waiters
# https://github.com/ansible-collections/community.aws/issues/433
unstable

cloud/aws
shippable/aws/group2

aws_kms_info
4 changes: 3 additions & 1 deletion tests/integration/targets/aws_secret/aliases
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# reason: missing-policy
unsupported
# reason: broken
# The tests for configuring secret rotation seem to be missing a permission
disabled

cloud/aws
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
cloud/aws
shippable/aws/group2

aws_step_functions_state_machine_execution
2 changes: 1 addition & 1 deletion tests/integration/targets/aws_waf_web_acl/aliases
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# reason: broken
# ansible/ansible#38258
unsupported
disabled

cloud/aws

Expand Down
5 changes: 3 additions & 2 deletions tests/integration/targets/cloudformation_exports_info/aliases
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
cloud/aws
shippable/aws/group3
# https://github.com/ansible-collections/community.aws/issues/157
unstable

cloud/aws
shippable/aws/group3
1 change: 1 addition & 0 deletions tests/integration/targets/cloudwatchlogs/aliases
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
cloud/aws
shippable/aws/group1

cloudwatchlogs_log_group
cloudwatchlogs_log_group_metric_filter
1 change: 1 addition & 0 deletions tests/integration/targets/connection/aliases
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
# Used to test basic operation once a connection plugin has established a connection
hidden
4 changes: 2 additions & 2 deletions tests/integration/targets/ec2_asg/aliases
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# reason: slow
# reason: broken
# Tests take around 30 minutes
unsupported
# reason: broken
disabled

cloud/aws
5 changes: 3 additions & 2 deletions tests/integration/targets/ec2_eip/aliases
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
cloud/aws
shippable/aws/group2
# https://github.com/ansible-collections/community.aws/issues/159
unstable

cloud/aws
shippable/aws/group2
1 change: 1 addition & 0 deletions tests/integration/targets/ec2_instance/aliases
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
cloud/aws
shippable/aws/group3

ec2_instance_info
1 change: 1 addition & 0 deletions tests/integration/targets/ec2_transit_gateway/aliases
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
cloud/aws
shippable/aws/group2

ec2_transit_gateway_info
1 change: 1 addition & 0 deletions tests/integration/targets/ec2_vpc_endpoint/aliases
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
cloud/aws
shippable/aws/group2

ec2_vpc_endpoint_info
1 change: 1 addition & 0 deletions tests/integration/targets/ec2_vpc_igw/aliases
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
cloud/aws
shippable/aws/group2

ec2_vpc_igw_info
8 changes: 5 additions & 3 deletions tests/integration/targets/ec2_vpc_nacl/aliases
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
ec2_vpc_nacl_info
cloud/aws
shippable/aws/group2
# https://github.com/ansible-collections/community.aws/issues/153
unstable

cloud/aws
shippable/aws/group2

ec2_vpc_nacl_info
8 changes: 7 additions & 1 deletion tests/integration/targets/ec2_vpc_route_table/aliases
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
# reason: boto2
# ec2_vpc_route_table_info is currently boto v2 based which means it can't handle API rate limiting
# https://github.com/ansible-collections/community.aws/issues/277 with AWSRetry
# would likely fix the issue.
unstable

cloud/aws
shippable/aws/group2
unstable

ec2_vpc_route_table_info
5 changes: 3 additions & 2 deletions tests/integration/targets/ec2_vpc_vgw/aliases
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
cloud/aws
shippable/aws/group2
# https://github.com/ansible-collections/community.aws/issues/154
unstable

cloud/aws
shippable/aws/group2
5 changes: 3 additions & 2 deletions tests/integration/targets/ec2_vpc_vpn_info/aliases
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
cloud/aws
shippable/aws/group3
# https://github.com/ansible-collections/community.aws/issues/156
unstable

cloud/aws
shippable/aws/group3
3 changes: 3 additions & 0 deletions tests/integration/targets/ecs_ecr/aliases
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
# reason: boto2
unstable

cloud/aws
shippable/aws/group2
5 changes: 5 additions & 0 deletions tests/integration/targets/elb_classic_lb/aliases
Original file line number Diff line number Diff line change
@@ -1,2 +1,7 @@
# reason: boto2
# elb_classic_lb is boto2 based which means that it handles rate limiting poorly
# https://github.com/ansible-collections/community.aws/issues/430
unstable

cloud/aws
shippable/aws/group2
6 changes: 4 additions & 2 deletions tests/integration/targets/elb_network_lb/aliases
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# reason:
unsupported
# reason: missing-policy
# reason: broken
# The SSL cert stored in the test has expired. Should be dynamically generated.
disabled

cloud/aws
3 changes: 2 additions & 1 deletion tests/integration/targets/elb_target/aliases
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
cloud/aws
elb_target_group
shippable/aws/group4

elb_target_group
1 change: 1 addition & 0 deletions tests/integration/targets/lambda/aliases
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
cloud/aws
shippable/aws/group2

execute_lambda
lambda_info
3 changes: 2 additions & 1 deletion tests/integration/targets/route53/aliases
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
route53_info
cloud/aws
shippable/aws/group2

route53_info
2 changes: 1 addition & 1 deletion tests/integration/targets/s3_logging/aliases
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# reason: unstable
# When running tests a failure rate of around 20% was observed
# https://github.com/ansible/ansible/issues/63520
unsupported

cloud/aws
Expand Down
1 change: 0 additions & 1 deletion tests/integration/targets/s3_sync/aliases
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
cloud/aws
shippable/aws/group1

0 comments on commit cb55efa

Please sign in to comment.