Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP DNM Migrate ec2_vpc_igw* modules and tests #408

Closed
wants to merge 21 commits into from
Closed

WIP DNM Migrate ec2_vpc_igw* modules and tests #408

wants to merge 21 commits into from

Conversation

alinabuzachis
Copy link
Contributor 

Migrate ec2_vpc_igw* modules and tests

jillr and others added 21 commits July 19, 2021 18:07
@jillr @alinabuzachis
Initial commit
4899268 
This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@eb75681
@jillr @alinabuzachis
migration test cleanup
40d402e 
This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@13b104b
@jillr @alinabuzachis
Rename collection (#12)
7b5218b 
* Rename core collection

Rename references to ansible.amazon to amazon.aws.

* Rename community.amazon to community.aws
Fix pep8 line lengths for rewritten amazon.aws imports

* Missed a path in shippable.sh
* Dependency repos moved

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@235c5db
@jillr @alinabuzachis
Remove METADATA and cleanup galaxy.yml (ansible-collections#70)
d3f67a1 
* Remove ANSIBLE_METADATA entirely, see ansible/ansible/pull/69454.
Remove `license` field from galaxy.yml, in favor of `license_file`.

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@05672a6
@jillr @alinabuzachis
Collections related fixes for CI (ansible-collections#96)
a733360 
* Update module deprecations

Switch version to `removed_at_date`

* Don't install amazon.aws from galaxy

We've been using galaxy to install amazon.aws in shippable, but that
doesn't really work if we aren't publising faster. Get that collection
from git so it is most up to date.

* We need to declare python test deps now

* missed a python dep

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@7cd211e
@Akasurde @alinabuzachis
Update Examples with FQCN (ansible-collections#67)
16b2b96 
Updated module examples with FQCN

Signed-off-by: Abhijeet Kasurde <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@98173ae
@flowerysong @alinabuzachis
Update module_utils paths to remove aws subdir (ansible-collections#23)
e090d13 
Co-authored-by: Ezekiel Hendrickson <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@10853d9
@jillr @alinabuzachis
Update docs (ansible-collections#99)
0ad961c 
* Update docs

Remove .git from repo url so links in readme will generate correctly
Add required ansible version
Run latest version of add_docs.py
Add version_added string to modules

* galaxy.yml was missing authors

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@96ee268
@Akasurde @alinabuzachis
Docs: sanity fixes (ansible-collections#133)
8545ba6 
Signed-off-by: Abhijeet Kasurde <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@059cf9e
@tremble @alinabuzachis
Bulk migration to AnsibleAWSModule (ansible-collections#173)
fd58ef4 
* Update comments to reference AnsibleAWSModule rather than AnsibleModule
* Bulk re-order imports and split onto one from import per-line.
* Add AnsibleAWSModule imports
* Migrate boto 2 based modules to AnsibleAWSModule
* Move boto3-only modules over to AnsibleAWSModule
* Remove extra ec2_argument_spec calls - not needed now we're using AnsibleAWSModule
* Remove most HAS_BOTO3 code, it's handled by AnsibleAWSModule
* Handle missing Boto 2 consistently  (HAS_BOTO)
* Remove AnsibleModule imports
* Changelog fragment

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@818c6d2
@tremble @alinabuzachis
Cleanup: Bulk Migration from boto3_conn to module.client() (ansible-c…
2bacd39 
…ollections#188)

* Migrate from boto3_conn to module.client
* Simplify error handling when creating connections
* Simplify Region handling
* Remove unused imports
* Changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@6bdf00d
@tremble @alinabuzachis
Cleanup IGW modules (ansible-collections#318)
505c1f6 
* import order

* Add retry decorators

* Switch tests to using module_defaults

* module_defaults

* Add initial _info tests

* Handle Boto Errors with fail_json_aws

* Test state=absent when IGW missing

* Support not purging tags

* Support converting Tags from boto to dict

* Add tagging tests

* Use random CIDR for VPC

* Add check_mode tests

* changelog

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@d6ff623
@tremble @alinabuzachis
Yet more integration test aliases file cleanup (ansible-collections#431)
47d33bd 
* More aliases cleanup
* Mark ec2_classic_lb tests unstable
* Add more comments about why tests aren't enabled

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb55efa
@alinabuzachis
ec2_vpc_igw: increase integration tests coverage and code cleaning (a…
7b57380 
…nsible-collections#386)

* Internet gateway: add missing integration tests and code check
 * Add CamelCase tags integration test
 * Removed check_input_tags() because useless as ansible_dict_to_boto3_tag_list() already performs a to_native() conversion to strings
 * Add additional integration tests for ec2_vpc_igw_info module

Signed-off-by: Alina Buzachis <[email protected]>

* Internet Gateway - integration tests
 * Fix Internet Gatways search by tags

* * Apply reviewer suggestions
        * Better error handling for the waiter

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cff6d00
@alinabuzachis @tremble
ec2_vpc_igw (_info) - documentation improvement (ansible-collections#495
5ee24f3 
)

* * ec2_vpc_igw (_info) - documentation improvement

Signed-off-by: Alina Buzachis <[email protected]>

* Whitespace linting

Co-authored-by: Mark Chappell <[email protected]>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@1a0c20c
@tremble @alinabuzachis
Update the default module requirements from python 2.6/boto to python…
7ae7be3 
… 3.6/boto3

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@c097c55
@jillr @alinabuzachis
Remove shippable references from repo
201e637 
This collection has been operating on Zuul CI for some weeks now

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@4e0d83c
@alinabuzachis
Update ignore files
76de081
@alinabuzachis
refresh runtime
4fdb163
@alinabuzachis
Update FQDN
29c6f3b
@alinabuzachis
Add changelog fragment
689b766
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@markuman
fix wrong element spec for rules param in aws_s3_cors (ansible-collec…
ba3bdcb 
…tions#408)

* ansible-collections#404 fix wrong element spec for rules param

* ansible-collections#404 documentation fix

Co-authored-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@markuman @abikouo
fix wrong element spec for rules param in aws_s3_cors (ansible-collec…
ad54f20 
…tions#408)

* ansible-collections#404 fix wrong element spec for rules param

* ansible-collections#404 documentation fix

Co-authored-by: Markus Bergholz <[email protected]>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@markuman
fix wrong element spec for rules param in aws_s3_cors (ansible-collec…
b36131b 
…tions#408)

* ansible-collections#404 fix wrong element spec for rules param

* ansible-collections#404 documentation fix

Co-authored-by: Markus Bergholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alinabuzachis @jillr @Akasurde @flowerysong @tremble