Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_instance - update network interface parameters #2123

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jun 4, 2024

SUMMARY

Closes #2054
JIRA: https://issues.redhat.com/browse/ACA-1382

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

ec2_instance

Copy link

github-actions bot commented Jun 4, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d41f8de5d4d0418481d95189877f4806

✔️ ansible-galaxy-importer SUCCESS in 4m 30s
✔️ build-ansible-collection SUCCESS in 15m 07s
✔️ ansible-test-splitter SUCCESS in 7m 07s
integration-amazon.aws-1 FAILURE in 6m 43s
integration-amazon.aws-2 FAILURE in 6m 39s
integration-amazon.aws-3 FAILURE in 7m 03s
integration-amazon.aws-4 FAILURE in 7m 26s
integration-amazon.aws-5 FAILURE in 7m 50s
integration-amazon.aws-6 FAILURE in 7m 01s
integration-amazon.aws-7 FAILURE in 7m 09s
integration-amazon.aws-8 FAILURE in 8m 49s
integration-amazon.aws-9 FAILURE in 8m 17s
integration-amazon.aws-10 FAILURE in 8m 40s
integration-amazon.aws-11 FAILURE in 7m 57s
integration-amazon.aws-12 FAILURE in 8m 13s
integration-amazon.aws-13 FAILURE in 8m 28s
integration-amazon.aws-14 FAILURE in 8m 15s
integration-amazon.aws-15 FAILURE in 10m 24s
integration-amazon.aws-16 FAILURE in 8m 23s
integration-amazon.aws-17 FAILURE in 17m 27s
integration-amazon.aws-18 FAILURE in 6m 44s
integration-amazon.aws-19 FAILURE in 8m 10s
Skipped 25 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9fa4379a890e44fca0ca3fb4f9be1968

✔️ ansible-galaxy-importer SUCCESS in 5m 39s
✔️ build-ansible-collection SUCCESS in 15m 27s
✔️ ansible-test-splitter SUCCESS in 6m 56s
integration-amazon.aws-1 FAILURE in 8m 49s
integration-amazon.aws-2 FAILURE in 8m 15s
integration-amazon.aws-3 FAILURE in 8m 25s
integration-amazon.aws-4 FAILURE in 8m 37s
integration-amazon.aws-5 FAILURE in 7m 54s
integration-amazon.aws-6 FAILURE in 8m 49s
integration-amazon.aws-7 FAILURE in 8m 18s
integration-amazon.aws-8 FAILURE in 9m 30s
integration-amazon.aws-9 FAILURE in 9m 21s
integration-amazon.aws-10 FAILURE in 8m 35s
integration-amazon.aws-11 FAILURE in 8m 28s
integration-amazon.aws-12 FAILURE in 12m 37s
integration-amazon.aws-13 RETRY_LIMIT in 1m 44s
integration-amazon.aws-14 FAILURE in 7m 09s
integration-amazon.aws-15 FAILURE in 8m 14s
integration-amazon.aws-16 FAILURE in 6m 39s
integration-amazon.aws-17 FAILURE in 8m 39s
integration-amazon.aws-18 FAILURE in 7m 57s
integration-amazon.aws-19 FAILURE in 7m 57s
✔️ integration-community.aws-1 SUCCESS in 34m 51s
Skipped 24 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/417e19d3ac594975b7ed474a45eafebc

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection RETRY_LIMIT in 6s
ansible-test-splitter POST_FAILURE in 12m 12s
⚠️ integration-amazon.aws-1 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-3 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-4 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-5 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-6 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-7 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-8 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-9 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-10 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-11 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-12 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-13 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-14 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-15 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-16 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-17 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-18 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-19 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-20 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-21 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-amazon.aws-22 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-1 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-3 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-4 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-5 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-6 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-7 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-8 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-9 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-10 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-11 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-12 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-13 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-14 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-15 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-16 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-17 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-18 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-19 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-20 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-21 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ integration-community.aws-22 SKIPPED Skipped due to failed job build-ansible-collection

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/22e5f77b69ac41e8acf7654b6f75df5b

⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection
build-ansible-collection RETRY_LIMIT in 6m 28s
ansible-test-splitter RETRY_LIMIT in 6m 36s
⚠️ integration-amazon.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter

@abikouo
Copy link
Contributor Author

abikouo commented Jun 11, 2024

recheck

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a2b703e498e84eccb4209aaf8285a8c7

✔️ ansible-galaxy-importer SUCCESS in 5m 21s
✔️ build-ansible-collection SUCCESS in 16m 08s
ansible-test-splitter RETRY_LIMIT Host unreachable in 4m 13s
⚠️ integration-amazon.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-amazon.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-1 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-2 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-3 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-4 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-5 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-6 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-7 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-8 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-9 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-10 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-11 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-12 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-13 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-14 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-15 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-16 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-17 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-18 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-19 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-20 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-21 SKIPPED Skipped due to failed job ansible-test-splitter
⚠️ integration-community.aws-22 SKIPPED Skipped due to failed job ansible-test-splitter

@abikouo
Copy link
Contributor Author

abikouo commented Jun 12, 2024

recheck

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/2f536f46270b4ae19b634dbab9bebd45

✔️ ansible-galaxy-importer SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 12m 58s
✔️ ansible-test-splitter SUCCESS in 5m 06s
integration-amazon.aws-1 FAILURE in 3m 52s
integration-amazon.aws-2 FAILURE in 3m 56s
integration-amazon.aws-3 FAILURE in 3m 59s
integration-amazon.aws-4 FAILURE in 5m 20s
integration-amazon.aws-5 FAILURE in 4m 26s
integration-amazon.aws-6 FAILURE in 5m 46s
integration-amazon.aws-7 FAILURE in 5m 14s
integration-amazon.aws-8 FAILURE in 3m 44s
integration-amazon.aws-9 FAILURE in 5m 09s
integration-amazon.aws-10 FAILURE in 5m 23s
integration-amazon.aws-11 FAILURE in 7m 27s
integration-amazon.aws-12 FAILURE in 5m 20s
integration-amazon.aws-13 FAILURE in 4m 00s
integration-amazon.aws-14 FAILURE in 5m 14s
integration-amazon.aws-15 FAILURE in 4m 53s
integration-amazon.aws-16 FAILURE in 3m 56s
integration-amazon.aws-17 FAILURE in 6m 03s
integration-amazon.aws-18 FAILURE in 3m 47s
integration-amazon.aws-19 FAILURE in 5m 13s
integration-amazon.aws-20 FAILURE in 5m 14s
integration-amazon.aws-21 FAILURE in 9m 10s
Skipped 23 jobs

@abikouo
Copy link
Contributor Author

abikouo commented Jun 12, 2024

recheck

Copy link
Contributor

This change depends on a change that failed to merge.

Change ansible/ansible-zuul-jobs#1866 is needed.

@abikouo abikouo closed this Jun 12, 2024
@abikouo abikouo reopened this Jun 12, 2024
@abikouo
Copy link
Contributor Author

abikouo commented Jun 12, 2024

recheck

@abikouo
Copy link
Contributor Author

abikouo commented Jun 12, 2024

recheck

@abikouo abikouo changed the title DNM - ec2_instance - update network interface parameters ec2_instance - update network interface parameters Jun 12, 2024
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c66b8b58fc7d4384bf7f9e9510449c35

✔️ ansible-galaxy-importer SUCCESS in 3m 57s
✔️ build-ansible-collection SUCCESS in 14m 35s
✔️ ansible-test-splitter SUCCESS in 5m 59s
✔️ integration-amazon.aws-1 SUCCESS in 27m 38s
✔️ integration-amazon.aws-2 SUCCESS in 9m 23s
✔️ integration-amazon.aws-3 SUCCESS in 12m 48s
✔️ integration-amazon.aws-4 SUCCESS in 7m 38s
✔️ integration-amazon.aws-5 SUCCESS in 8m 02s
✔️ integration-amazon.aws-6 SUCCESS in 11m 18s
✔️ integration-amazon.aws-7 SUCCESS in 7m 29s
✔️ integration-amazon.aws-8 SUCCESS in 14m 21s
✔️ integration-amazon.aws-9 SUCCESS in 7m 27s
✔️ integration-amazon.aws-10 SUCCESS in 17m 00s
✔️ integration-amazon.aws-11 SUCCESS in 12m 11s
✔️ integration-amazon.aws-12 SUCCESS in 6m 46s
✔️ integration-amazon.aws-13 SUCCESS in 13m 37s
✔️ integration-amazon.aws-14 SUCCESS in 10m 48s
✔️ integration-amazon.aws-15 SUCCESS in 10m 26s
✔️ integration-amazon.aws-16 SUCCESS in 13m 09s
✔️ integration-amazon.aws-17 SUCCESS in 8m 50s
✔️ integration-amazon.aws-18 SUCCESS in 6m 24s
✔️ integration-amazon.aws-19 SUCCESS in 7m 51s
✔️ integration-amazon.aws-20 SUCCESS in 11m 57s
✔️ integration-amazon.aws-21 SUCCESS in 21m 49s
Skipped 23 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d31c6d9f25f1467682bea38b6d5708cc

✔️ ansible-galaxy-importer SUCCESS in 4m 13s
✔️ build-ansible-collection SUCCESS in 13m 11s
✔️ ansible-test-splitter SUCCESS in 5m 30s
✔️ integration-amazon.aws-1 SUCCESS in 18m 51s
✔️ integration-amazon.aws-2 SUCCESS in 9m 05s
✔️ integration-amazon.aws-3 SUCCESS in 9m 13s
✔️ integration-amazon.aws-4 SUCCESS in 11m 05s
✔️ integration-amazon.aws-5 SUCCESS in 7m 34s
✔️ integration-amazon.aws-6 SUCCESS in 5m 29s
✔️ integration-amazon.aws-7 SUCCESS in 7m 04s
integration-amazon.aws-8 FAILURE in 11m 53s
✔️ integration-amazon.aws-9 SUCCESS in 12m 30s
✔️ integration-amazon.aws-10 SUCCESS in 7m 26s
✔️ integration-amazon.aws-11 SUCCESS in 16m 31s
✔️ integration-amazon.aws-12 SUCCESS in 16m 31s
✔️ integration-amazon.aws-13 SUCCESS in 11m 26s
✔️ integration-amazon.aws-14 SUCCESS in 11m 04s
✔️ integration-amazon.aws-15 SUCCESS in 10m 55s
✔️ integration-amazon.aws-16 SUCCESS in 7m 19s
✔️ integration-amazon.aws-17 SUCCESS in 7m 20s
✔️ integration-amazon.aws-18 SUCCESS in 10m 42s
✔️ integration-amazon.aws-19 SUCCESS in 6m 51s
✔️ integration-amazon.aws-20 SUCCESS in 7m 32s
✔️ integration-amazon.aws-21 SUCCESS in 21m 46s
Skipped 23 jobs

plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Show resolved Hide resolved
plugins/modules/ec2_instance.py Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Show resolved Hide resolved
plugins/modules/ec2_instance.py Show resolved Hide resolved
plugins/modules/ec2_instance.py Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be really careful with some of these suggested changes.

When a parameter isn't passed in Ansible, the key will be set, but the value will be None. This is not the same as the key simply not being set...

@abikouo
Copy link
Contributor Author

abikouo commented Jun 26, 2024

Please be really careful with some of these suggested changes.

When a parameter isn't passed in Ansible, the key will be set, but the value will be None. This is not the same as the key simply not being set...

Yes this is what I said in most of the comments

@abikouo
Copy link
Contributor Author

abikouo commented Jun 26, 2024

recheck

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/bb6068174f814e2a908dd270d5ac1add

✔️ ansible-galaxy-importer SUCCESS in 4m 06s
✔️ build-ansible-collection SUCCESS in 12m 23s
✔️ ansible-test-splitter SUCCESS in 5m 07s
✔️ integration-amazon.aws-1 SUCCESS in 21m 56s
✔️ integration-amazon.aws-2 SUCCESS in 12m 39s
✔️ integration-amazon.aws-3 SUCCESS in 12m 15s
✔️ integration-amazon.aws-4 SUCCESS in 7m 15s
✔️ integration-amazon.aws-5 SUCCESS in 10m 44s
✔️ integration-amazon.aws-6 SUCCESS in 6m 21s
✔️ integration-amazon.aws-7 SUCCESS in 9m 21s
integration-amazon.aws-8 FAILURE in 11m 37s
✔️ integration-amazon.aws-9 SUCCESS in 11m 38s
✔️ integration-amazon.aws-10 SUCCESS in 7m 01s
✔️ integration-amazon.aws-11 SUCCESS in 11m 58s
✔️ integration-amazon.aws-12 SUCCESS in 15m 21s
✔️ integration-amazon.aws-13 SUCCESS in 13m 32s
✔️ integration-amazon.aws-14 SUCCESS in 14m 30s
✔️ integration-amazon.aws-15 SUCCESS in 11m 21s
✔️ integration-amazon.aws-16 SUCCESS in 7m 46s
✔️ integration-amazon.aws-17 SUCCESS in 15m 23s
✔️ integration-amazon.aws-18 SUCCESS in 8m 10s
✔️ integration-amazon.aws-19 SUCCESS in 7m 23s
✔️ integration-amazon.aws-20 SUCCESS in 8m 53s
✔️ integration-amazon.aws-21 SUCCESS in 19m 41s
Skipped 23 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/0846b673a5224f35936b1184245b9f41

✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 12m 40s
✔️ ansible-test-splitter SUCCESS in 5m 15s
✔️ integration-amazon.aws-1 SUCCESS in 17m 55s
✔️ integration-amazon.aws-2 SUCCESS in 12m 39s
✔️ integration-amazon.aws-3 SUCCESS in 11m 05s
✔️ integration-amazon.aws-4 SUCCESS in 11m 38s
✔️ integration-amazon.aws-5 SUCCESS in 7m 46s
✔️ integration-amazon.aws-6 SUCCESS in 6m 11s
✔️ integration-amazon.aws-7 SUCCESS in 6m 50s
integration-amazon.aws-8 FAILURE in 10m 59s
✔️ integration-amazon.aws-9 SUCCESS in 8m 14s
✔️ integration-amazon.aws-10 SUCCESS in 10m 29s
✔️ integration-amazon.aws-11 SUCCESS in 10m 28s
✔️ integration-amazon.aws-12 SUCCESS in 10m 19s
✔️ integration-amazon.aws-13 SUCCESS in 15m 24s
✔️ integration-amazon.aws-14 SUCCESS in 11m 43s
✔️ integration-amazon.aws-15 SUCCESS in 7m 46s
✔️ integration-amazon.aws-16 SUCCESS in 7m 16s
✔️ integration-amazon.aws-17 SUCCESS in 8m 17s
✔️ integration-amazon.aws-18 SUCCESS in 11m 14s
✔️ integration-amazon.aws-19 SUCCESS in 10m 15s
✔️ integration-amazon.aws-20 SUCCESS in 8m 34s
✔️ integration-amazon.aws-21 SUCCESS in 18m 26s
Skipped 23 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/34a706c110914a77b8e05eddfacf82b8

✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 12m 14s
✔️ ansible-test-splitter SUCCESS in 4m 56s
✔️ integration-amazon.aws-1 SUCCESS in 17m 40s
✔️ integration-amazon.aws-2 SUCCESS in 12m 22s
✔️ integration-amazon.aws-3 SUCCESS in 8m 35s
✔️ integration-amazon.aws-4 SUCCESS in 7m 33s
✔️ integration-amazon.aws-5 SUCCESS in 11m 39s
✔️ integration-amazon.aws-6 SUCCESS in 6m 47s
integration-amazon.aws-7 FAILURE in 7m 36s
integration-amazon.aws-8 FAILURE in 11m 29s
✔️ integration-amazon.aws-9 SUCCESS in 8m 36s
✔️ integration-amazon.aws-10 SUCCESS in 7m 09s
✔️ integration-amazon.aws-11 SUCCESS in 7m 07s
✔️ integration-amazon.aws-12 SUCCESS in 7m 08s
✔️ integration-amazon.aws-13 SUCCESS in 12m 10s
✔️ integration-amazon.aws-14 SUCCESS in 7m 18s
✔️ integration-amazon.aws-15 SUCCESS in 7m 34s
✔️ integration-amazon.aws-16 SUCCESS in 6m 23s
✔️ integration-amazon.aws-17 SUCCESS in 7m 17s
✔️ integration-amazon.aws-18 SUCCESS in 9m 53s
✔️ integration-amazon.aws-19 SUCCESS in 7m 50s
✔️ integration-amazon.aws-20 SUCCESS in 8m 26s
✔️ integration-amazon.aws-21 SUCCESS in 19m 00s
Skipped 23 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/08db870dcac7456ba3c5d846ecbda512

✔️ ansible-galaxy-importer SUCCESS in 8m 22s
✔️ build-ansible-collection SUCCESS in 12m 11s
✔️ ansible-test-splitter SUCCESS in 4m 56s
✔️ integration-amazon.aws-1 SUCCESS in 24m 28s
✔️ integration-amazon.aws-2 SUCCESS in 7m 45s
✔️ integration-amazon.aws-3 SUCCESS in 11m 44s
✔️ integration-amazon.aws-4 SUCCESS in 8m 01s
✔️ integration-amazon.aws-5 SUCCESS in 7m 48s
✔️ integration-amazon.aws-6 SUCCESS in 6m 11s
integration-amazon.aws-7 FAILURE in 6m 46s
integration-amazon.aws-8 FAILURE in 11m 44s
✔️ integration-amazon.aws-9 SUCCESS in 8m 24s
✔️ integration-amazon.aws-10 SUCCESS in 7m 27s
✔️ integration-amazon.aws-11 SUCCESS in 11m 37s
✔️ integration-amazon.aws-12 SUCCESS in 12m 40s
✔️ integration-amazon.aws-13 SUCCESS in 12m 58s
✔️ integration-amazon.aws-14 SUCCESS in 10m 18s
✔️ integration-amazon.aws-15 SUCCESS in 9m 50s
✔️ integration-amazon.aws-16 SUCCESS in 6m 22s
✔️ integration-amazon.aws-17 SUCCESS in 8m 00s
✔️ integration-amazon.aws-18 SUCCESS in 7m 34s
✔️ integration-amazon.aws-19 SUCCESS in 11m 37s
✔️ integration-amazon.aws-20 SUCCESS in 7m 57s
✔️ integration-amazon.aws-21 SUCCESS in 19m 16s
Skipped 23 jobs

@abikouo
Copy link
Contributor Author

abikouo commented Jun 27, 2024

recheck

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5fed7eb4e4b24efea3bbfcaeaf0a154b

✔️ ansible-galaxy-importer SUCCESS in 8m 57s
✔️ build-ansible-collection SUCCESS in 12m 19s
✔️ ansible-test-splitter SUCCESS in 4m 50s
✔️ integration-amazon.aws-1 SUCCESS in 18m 12s
✔️ integration-amazon.aws-2 SUCCESS in 11m 16s
✔️ integration-amazon.aws-3 SUCCESS in 8m 38s
✔️ integration-amazon.aws-4 SUCCESS in 6m 20s
✔️ integration-amazon.aws-5 SUCCESS in 7m 44s
✔️ integration-amazon.aws-6 SUCCESS in 5m 23s
integration-amazon.aws-7 FAILURE in 7m 35s
integration-amazon.aws-8 FAILURE in 12m 56s
✔️ integration-amazon.aws-9 SUCCESS in 8m 21s
✔️ integration-amazon.aws-10 SUCCESS in 7m 12s
✔️ integration-amazon.aws-11 SUCCESS in 11m 04s
✔️ integration-amazon.aws-12 SUCCESS in 6m 51s
✔️ integration-amazon.aws-13 SUCCESS in 13m 10s
✔️ integration-amazon.aws-14 SUCCESS in 7m 39s
✔️ integration-amazon.aws-15 SUCCESS in 10m 31s
✔️ integration-amazon.aws-16 SUCCESS in 7m 26s
✔️ integration-amazon.aws-17 SUCCESS in 8m 17s
✔️ integration-amazon.aws-18 SUCCESS in 10m 28s
✔️ integration-amazon.aws-19 SUCCESS in 6m 27s
✔️ integration-amazon.aws-20 SUCCESS in 8m 11s
✔️ integration-amazon.aws-21 SUCCESS in 21m 02s
Skipped 23 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/7f64429306ac43dd9f588e187fbee7e5

✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 12m 29s
✔️ ansible-test-splitter SUCCESS in 4m 59s
✔️ integration-amazon.aws-1 SUCCESS in 26m 21s
✔️ integration-amazon.aws-2 SUCCESS in 16m 14s
✔️ integration-amazon.aws-3 SUCCESS in 12m 51s
✔️ integration-amazon.aws-4 SUCCESS in 14m 26s
✔️ integration-amazon.aws-5 SUCCESS in 8m 33s
✔️ integration-amazon.aws-6 SUCCESS in 6m 22s
integration-amazon.aws-7 FAILURE in 7m 35s
integration-amazon.aws-8 FAILURE in 12m 00s
✔️ integration-amazon.aws-9 SUCCESS in 11m 31s
✔️ integration-amazon.aws-10 SUCCESS in 10m 51s
✔️ integration-amazon.aws-11 SUCCESS in 8m 10s
✔️ integration-amazon.aws-12 SUCCESS in 12m 24s
✔️ integration-amazon.aws-13 SUCCESS in 12m 09s
✔️ integration-amazon.aws-14 SUCCESS in 13m 40s
✔️ integration-amazon.aws-15 SUCCESS in 14m 11s
✔️ integration-amazon.aws-16 SUCCESS in 10m 02s
✔️ integration-amazon.aws-17 SUCCESS in 11m 14s
✔️ integration-amazon.aws-18 SUCCESS in 7m 16s
✔️ integration-amazon.aws-19 SUCCESS in 6m 59s
✔️ integration-amazon.aws-20 SUCCESS in 8m 43s
✔️ integration-amazon.aws-21 SUCCESS in 25m 20s
Skipped 23 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ca7f89265a074a49a7c76feef32250eb

✔️ ansible-galaxy-importer SUCCESS in 4m 17s
✔️ build-ansible-collection SUCCESS in 13m 19s
✔️ ansible-test-splitter SUCCESS in 5m 08s
✔️ integration-amazon.aws-1 SUCCESS in 15m 35s
✔️ integration-amazon.aws-2 SUCCESS in 8m 26s
✔️ integration-amazon.aws-3 SUCCESS in 10m 37s
✔️ integration-amazon.aws-4 SUCCESS in 12m 55s
✔️ integration-amazon.aws-5 SUCCESS in 8m 03s
✔️ integration-amazon.aws-6 SUCCESS in 9m 37s
integration-amazon.aws-7 FAILURE in 14m 27s
integration-amazon.aws-8 FAILURE in 12m 17s
✔️ integration-amazon.aws-9 SUCCESS in 12m 36s
✔️ integration-amazon.aws-10 SUCCESS in 11m 00s
✔️ integration-amazon.aws-11 SUCCESS in 10m 29s
✔️ integration-amazon.aws-12 SUCCESS in 10m 56s
✔️ integration-amazon.aws-13 SUCCESS in 11m 16s
✔️ integration-amazon.aws-14 SUCCESS in 7m 20s
✔️ integration-amazon.aws-15 SUCCESS in 12m 12s
✔️ integration-amazon.aws-16 SUCCESS in 7m 26s
✔️ integration-amazon.aws-17 SUCCESS in 9m 18s
✔️ integration-amazon.aws-18 SUCCESS in 7m 52s
✔️ integration-amazon.aws-19 SUCCESS in 6m 45s
✔️ integration-amazon.aws-20 SUCCESS in 7m 55s
✔️ integration-amazon.aws-21 SUCCESS in 24m 50s
Skipped 23 jobs

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a5b7c2fea573406ab7bb2390eaef1422

✔️ ansible-galaxy-importer SUCCESS in 3m 20s
✔️ build-ansible-collection SUCCESS in 12m 12s
✔️ ansible-test-splitter SUCCESS in 4m 55s
✔️ integration-amazon.aws-1 SUCCESS in 33m 57s
✔️ integration-amazon.aws-2 SUCCESS in 17m 09s
✔️ integration-amazon.aws-3 SUCCESS in 14m 51s
✔️ integration-amazon.aws-4 SUCCESS in 11m 14s
✔️ integration-amazon.aws-5 SUCCESS in 12m 35s
✔️ integration-amazon.aws-6 SUCCESS in 6m 27s
✔️ integration-amazon.aws-7 SUCCESS in 5m 48s
integration-amazon.aws-8 FAILURE in 11m 37s
✔️ integration-amazon.aws-9 SUCCESS in 11m 44s
✔️ integration-amazon.aws-10 SUCCESS in 10m 36s
✔️ integration-amazon.aws-11 SUCCESS in 10m 49s
✔️ integration-amazon.aws-12 SUCCESS in 7m 07s
✔️ integration-amazon.aws-13 SUCCESS in 10m 59s
✔️ integration-amazon.aws-14 SUCCESS in 10m 23s
✔️ integration-amazon.aws-15 SUCCESS in 11m 55s
✔️ integration-amazon.aws-16 SUCCESS in 7m 45s
✔️ integration-amazon.aws-17 SUCCESS in 16m 39s
✔️ integration-amazon.aws-18 SUCCESS in 6m 16s
✔️ integration-amazon.aws-19 SUCCESS in 8m 26s
✔️ integration-amazon.aws-20 SUCCESS in 7m 00s
✔️ integration-amazon.aws-21 SUCCESS in 19m 14s
Skipped 23 jobs

@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Jul 1, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/6a350fb01b5a4a539031717b7b36d462

✔️ ansible-galaxy-importer SUCCESS in 3m 50s
✔️ build-ansible-collection SUCCESS in 12m 42s
✔️ ansible-test-splitter SUCCESS in 5m 01s
✔️ integration-amazon.aws-1 SUCCESS in 29m 07s
✔️ integration-amazon.aws-2 SUCCESS in 15m 35s
✔️ integration-amazon.aws-3 SUCCESS in 12m 18s
✔️ integration-amazon.aws-4 SUCCESS in 10m 11s
✔️ integration-amazon.aws-5 SUCCESS in 7m 46s
✔️ integration-amazon.aws-6 SUCCESS in 5m 50s
✔️ integration-amazon.aws-7 SUCCESS in 5m 52s
✔️ integration-amazon.aws-8 SUCCESS in 8m 44s
✔️ integration-amazon.aws-9 SUCCESS in 12m 58s
✔️ integration-amazon.aws-10 SUCCESS in 10m 21s
✔️ integration-amazon.aws-11 SUCCESS in 10m 31s
✔️ integration-amazon.aws-12 SUCCESS in 10m 10s
✔️ integration-amazon.aws-13 SUCCESS in 12m 29s
✔️ integration-amazon.aws-14 SUCCESS in 11m 15s
✔️ integration-amazon.aws-15 SUCCESS in 11m 56s
✔️ integration-amazon.aws-16 SUCCESS in 7m 33s
✔️ integration-amazon.aws-17 SUCCESS in 7m 46s
✔️ integration-amazon.aws-18 SUCCESS in 6m 02s
✔️ integration-amazon.aws-19 SUCCESS in 8m 06s
✔️ integration-amazon.aws-20 SUCCESS in 8m 00s
✔️ integration-amazon.aws-21 SUCCESS in 23m 16s
Skipped 23 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit f7d7ffa into ansible-collections:main Jul 1, 2024
36 of 37 checks passed
@tremble tremble added the backport-8 PR should be backported to the stable-8 branch label Aug 28, 2024
Copy link

patchback bot commented Aug 28, 2024

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/f7d7ffa587b9dce7e0533202b88f81404a92e12c/pr-2123

Backported as #2258

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 28, 2024
SUMMARY

Closes #2054
JIRA: https://issues.redhat.com/browse/ACA-1382

ISSUE TYPE

Bugfix Pull Request
Feature Pull Request

COMPONENT NAME

ec2_instance

Reviewed-by: GomathiselviS
Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: Mark Chappell
(cherry picked from commit f7d7ffa)
tremble pushed a commit that referenced this pull request Aug 28, 2024
SUMMARY

Closes #2054
JIRA: https://issues.redhat.com/browse/ACA-1382

ISSUE TYPE

Bugfix Pull Request
Feature Pull Request

COMPONENT NAME

ec2_instance

Reviewed-by: GomathiselviS
Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: Mark Chappell
(cherry picked from commit f7d7ffa)

Co-authored-by: Bikouo Aubin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8 PR should be backported to the stable-8 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify and fully implement ec2_instance network option logic
4 participants