Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1213/e436817c backport][stable-5] ec2_security_group - Deprecate automatic flattening of lists passed to cidr_ip and cidr_ipv6 #1215

Commits on Oct 27, 2022

  1. ec2_security_group - Deprecate automatic flattening of lists passed t…

    …o cidr_ip and cidr_ipv6 (#1213)
    
    ec2_security_group - Deprecate automatic flattening of lists passed to cidr_ip and cidr_ipv6
    
    SUMMARY
    ec2_security_group currently has its own "flatten" implementation built into the evaluation of cidr_ip and cidr_ipv6, which allows folks to do things like:
      - ec2_security_group:
          name: '{{ ec2_group_name }}'
          description: '{{ ec2_group_description }}'
          state: present
          rules:
          - proto: "tcp"
            from_port: 8182
            to_port: 8182
            cidr_ipv6:
              - "64:ff9b::/96"
              - ["2620::/32"]
          - proto: "tcp"
            ports: 5665
            cidr_ip:
              - 172.16.1.0/24
              - 172.16.17.0/24
              - ["10.0.0.0/24", "10.20.0.0/24"]
    
    Support for this was originally added prior to the addition of the flatten filter in Ansible 2.5.  Behaviour like this isn't consistent with our other modules and adds additional complexity to an already very complex module.
    ISSUE TYPE
    
    Feature Pull Request
    
    COMPONENT NAME
    ec2_security_group
    ADDITIONAL INFORMATION
    
    Reviewed-by: Alina Buzachis <None>
    Reviewed-by: Mark Chappell <None>
    (cherry picked from commit e436817)
    tremble authored and patchback[bot] committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    f22c84d View commit details
    Browse the repository at this point in the history