[PR #1213/e436817c backport][stable-5] ec2_security_group - Deprecate automatic flattening of lists passed to cidr_ip and cidr_ipv6 #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…o cidr_ip and cidr_ipv6 (#1213) ec2_security_group - Deprecate automatic flattening of lists passed to cidr_ip and cidr_ipv6 SUMMARY ec2_security_group currently has its own "flatten" implementation built into the evaluation of cidr_ip and cidr_ipv6, which allows folks to do things like: - ec2_security_group: name: '{{ ec2_group_name }}' description: '{{ ec2_group_description }}' state: present rules: - proto: "tcp" from_port: 8182 to_port: 8182 cidr_ipv6: - "64:ff9b::/96" - ["2620::/32"] - proto: "tcp" ports: 5665 cidr_ip: - 172.16.1.0/24 - 172.16.17.0/24 - ["10.0.0.0/24", "10.20.0.0/24"] Support for this was originally added prior to the addition of the flatten filter in Ansible 2.5. Behaviour like this isn't consistent with our other modules and adds additional complexity to an already very complex module. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_security_group ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> (cherry picked from commit e436817)
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
tremble
approved these changes
Oct 27, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-5/e436817c2326e63c5ff3bf2fb88be70eb60cb263/pr-1213
branch
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
) ecs_service - document circuit breaker feature SUMMARY Fixes ansible-collections#921 This feature works with the existing code, so this was mainly adding documentation, examples, and an integration test. ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION The deployment circuit breaker is part of the deployment configuration dictionary, which is already snake<=>camel cased. Thus the existing code was handling 99% of the feature, we just added some type validation, documentation, examples, and an integration test. - community.aws.ecs_service: state: present name: test-service cluster: test-cluster task_definition: test-task-definition desired_count: 3 deployment_configuration: deployment_circuit_breaker: enable: True rollback: True Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
) ecs_service - document circuit breaker feature SUMMARY Fixes ansible-collections#921 This feature works with the existing code, so this was mainly adding documentation, examples, and an integration test. ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION The deployment circuit breaker is part of the deployment configuration dictionary, which is already snake<=>camel cased. Thus the existing code was handling 99% of the feature, we just added some type validation, documentation, examples, and an integration test. - community.aws.ecs_service: state: present name: test-service cluster: test-cluster task_definition: test-task-definition desired_count: 3 deployment_configuration: deployment_circuit_breaker: enable: True rollback: True Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
) ecs_service - document circuit breaker feature SUMMARY Fixes ansible-collections#921 This feature works with the existing code, so this was mainly adding documentation, examples, and an integration test. ISSUE TYPE Feature Pull Request COMPONENT NAME ecs_service ADDITIONAL INFORMATION The deployment circuit breaker is part of the deployment configuration dictionary, which is already snake<=>camel cased. Thus the existing code was handling 99% of the feature, we just added some type validation, documentation, examples, and an integration test. - community.aws.ecs_service: state: present name: test-service cluster: test-cluster task_definition: test-task-definition desired_count: 3 deployment_configuration: deployment_circuit_breaker: enable: True rollback: True Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
fix assert of deploymentCircuitBreaker SUMMARY fix broken ecs_cluster integration test of ansible-collections#1215 cc @tremble @karcadia ISSUE TYPE COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1213 as merged into main (e436817).
SUMMARY
ec2_security_groupcurrently has its own "flatten" implementation built into the evaluation ofcidr_ipandcidr_ipv6, which allows folks to do things like:Support for this was originally added prior to the addition of the
flattenfilter in Ansible 2.5. Behaviour like this isn't consistent with our other modules and adds additional complexity to an already very complex module.ISSUE TYPE
COMPONENT NAME
ec2_security_group
ADDITIONAL INFORMATION