Repository navigation
Conversation
Contributor
|
are we sure this isnt a bun bug? |
Contributor
Author
|
Did some extra tests, It is a bun bug. adding https://github.com/oven-sh/bun/blob/main/src/cli.zig#L687-L698 Im not sure if its deliberate from them, but if it is then our solutions are to remove the execArgv or just force to use a null config |
Contributor
Author
|
Made a PR that should ideally fix it, lets see what the team thinks of it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a real complete fix, as it still doesnt answer why the toml is loaded even when compiled to disable it.
But adding a null config path to the execArgs works
https://bun.com/docs/runtime#param-config
Potential fix to #5349