fix(opencode): teach Kit's test what an ID is#17745
Merged
Hona merged 1 commit intoanomalyco:devfrom Mar 16, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a typecheck regression in packages/opencode tests after branded ID types were introduced, by ensuring test fixtures use the appropriate strong ID wrappers instead of raw strings.
Changes:
- Wrap
providerID/model.idpassed toProvider.getModelwithProviderID.makeandModelID.make. - Wrap literal session/message identifiers with
SessionID.makeandMessageID.make. - Update the message
model.providerIDfield to use the brandedProviderID.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ConanXu-math
pushed a commit
to ConanXu-math/opencode
that referenced
this pull request
Mar 17, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llm.test.tsIDs withProviderID.make,ModelID.make,SessionID.make, andMessageID.makeTesting
bun run typecheckinpackages/opencodebun test test/session/llm.test.ts --test-name-pattern \"keeps tools enabled by prompt permissions\"git push -u origin fix/llm-test-strong-ids(pre-push hook runs repo typecheck)