Skip to content

fix(opencode): teach Kit's test what an ID is#17745

Merged
Hona merged 1 commit intoanomalyco:devfrom
Hona:fix/llm-test-strong-ids
Mar 16, 2026
Merged

fix(opencode): teach Kit's test what an ID is#17745
Hona merged 1 commit intoanomalyco:devfrom
Hona:fix/llm-test-strong-ids

Conversation

@Hona
Copy link
Member

@Hona Hona commented Mar 16, 2026

Summary

Testing

  • bun run typecheck in packages/opencode
  • bun test test/session/llm.test.ts --test-name-pattern \"keeps tools enabled by prompt permissions\"
  • git push -u origin fix/llm-test-strong-ids (pre-push hook runs repo typecheck)

Copilot AI review requested due to automatic review settings March 16, 2026 07:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a typecheck regression in packages/opencode tests after branded ID types were introduced, by ensuring test fixtures use the appropriate strong ID wrappers instead of raw strings.

Changes:

  • Wrap providerID / model.id passed to Provider.getModel with ProviderID.make and ModelID.make.
  • Wrap literal session/message identifiers with SessionID.make and MessageID.make.
  • Update the message model.providerID field to use the branded ProviderID.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Hona Hona merged commit 59c530c into anomalyco:dev Mar 16, 2026
15 checks passed
ConanXu-math pushed a commit to ConanXu-math/opencode that referenced this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants